Working directory checks on startup #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subnetmarco
force-pushed
the
chore/check-working-dir
branch
from
c15d7b0
to
515fe06
Compare
| if exit_code ~= 0 then | ||
| return false, "Cannot create the working directory at "..working_dir | ||
| else | ||
| local _, exit_code = IO.os_execute("chmod -R +wr "..working_dir) |
There was a problem hiding this comment.
This is the only thing that I don't really like in this PR. It is kinda overriding the user's umask setting, which should be preserved. Ok for checking the permissions before booting, not so ok to mess up with a user's settings.
There was a problem hiding this comment.
We don't really have other options. Kong will not work if +wr is not set on the folder.
subnetmarco
force-pushed
the
chore/check-working-dir
branch
from
515fe06
to
ef5acef
Compare
subnetmarco
added
pr/ready (but hold merge)
subnetmarco
added a commit
that referenced
this pull request
Feb 6, 2016
Working directory checks on startup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following checks to the Kong startup logic:
On a side note
nginx_working_dirshould be renamed in the future toworking_dirorkong_working_dirsince it's not specific to nginx anymore.