fix(otel): use BatchQueue to avoid worker-level table data race
#9504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayocream
force-pushed
the
fix/otel-data-race
branch
from
82068cd
to
ae92250
Compare
sumimakito
changed the title
|
Oops, thanks for fixing the title typo @sumimakito (*´∇｀*) |
chronolaw
changed the title
dndx
reviewed
Oct 17, 2022
|
|
||
| spans_queue[len] = pb_span | ||
| spans_queue.n = len | ||
| insert(spans_queue, pb_span) |
There was a problem hiding this comment.
This might be slow as table length is actually relatively expensive to calculate in Lua. It is common to store the length of the array in spans_queue[0] and then do the previous logic instead.
There was a problem hiding this comment.
Thanks for noticing, used BatchQueue to replace the worker-level cache table. I have an idea that only the privileged worker handles the queue and sends requests; the other workers insert data into the queue through the new events library. That could reduce the performance impact on normal workers.
|
Discussed with @mayocream we will need more work to properly fix this issue, thus moving out of 3.01 scope |
mayocream
force-pushed
the
fix/otel-data-race
branch
from
23d2cf2
to
553fae9
Compare
mayocream
changed the title
BatchQueue to avoid worker-level table data race
mayocream
force-pushed
the
fix/otel-data-race
branch
from
75fce4c
to
b978858
Compare
fffonion
approved these changes
Oct 28, 2022
mayocream
added a commit
that referenced
this pull request
Nov 2, 2022
fffonion
pushed a commit
that referenced
this pull request
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue where OpenTelemetry spans are randomly stripped and not sent to the backend.