Skip to content

Commit

Permalink
chore: remove #3393 todo (#3403)
Browse files Browse the repository at this point in the history
  • Loading branch information
czeslavo committed Jan 18, 2023
1 parent 2ff988a commit 59d047f
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions test/e2e/features_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (
"fmt"
"net/http"
"os"
"os/exec"
"strings"
"testing"
"time"
Expand Down Expand Up @@ -308,12 +307,6 @@ func TestDeployAllInOneDBLESSGateway(t *testing.T) {
LabelSelector: "app=" + deployment.Name,
}

t.Log("running the admission webhook setup script")
deployAdmissionWebhook(t, env)

// TODO: make sure that KongConsumer cannot be created due to admission webhook rejecting duplicates
// https://github.com/Kong/kubernetes-ingress-controller/issues/3393

t.Log("verifying that KIC disabled controllers for Gateway API and printed proper log")
require.Eventually(t, func() bool {
pods, err := env.Cluster().Client().CoreV1().Pods(deployment.Namespace).List(ctx, deploymentListOptions)
Expand Down Expand Up @@ -449,13 +442,6 @@ func TestDeployAllInOneDBLESSGateway(t *testing.T) {
verifyTCPRoute(ctx, t, env)
}

func deployAdmissionWebhook(t *testing.T, env environments.Environment) {
kubeconfig := getTemporaryKubeconfig(t, env)
cmd := exec.Command("bash", admissionScriptPath, kubeconfig)
out, err := cmd.CombinedOutput()
require.NoError(t, err, "running command failed: %s", string(out))
}

// Unsatisfied LoadBalancers have special handling, see
// https://github.com/Kong/kubernetes-ingress-controller/issues/2001
func TestDeployAllInOneDBLESSNoLoadBalancer(t *testing.T) {
Expand Down

0 comments on commit 59d047f

Please sign in to comment.