Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove #3393 todo #3403

Merged
merged 1 commit into from
Jan 18, 2023
Merged

chore: remove #3393 todo #3403

merged 1 commit into from
Jan 18, 2023

Conversation

czeslavo
Copy link
Contributor

What this PR does / why we need it:

As the admission webhook itself is already tested in many aspects in integration tests, we prefer to remove this check completely from the E2Es.

Which issue this PR fixes:

Closes #3393.

@czeslavo czeslavo requested a review from a team as a code owner January 18, 2023 19:15
@czeslavo czeslavo self-assigned this Jan 18, 2023
@czeslavo czeslavo added the area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. label Jan 18, 2023
@czeslavo czeslavo enabled auto-merge (squash) January 18, 2023 19:26
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 73.9% // Head: 74.0% // Increases project coverage by +0.0% 🎉

Coverage data is based on head (8e67b88) compared to base (bf32874).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3403   +/-   ##
=====================================
  Coverage   73.9%   74.0%           
=====================================
  Files        113     113           
  Lines      13896   13896           
=====================================
+ Hits       10282   10287    +5     
+ Misses      2963    2960    -3     
+ Partials     651     649    -2     
Impacted Files Coverage Δ
internal/dataplane/parser/parser.go 90.4% <0.0%> (-1.7%) ⬇️
...ternal/controllers/gateway/httproute_controller.go 58.3% <0.0%> (+1.1%) ⬆️
...nternal/controllers/gateway/tcproute_controller.go 72.0% <0.0%> (+2.0%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czeslavo czeslavo merged commit 59d047f into main Jan 18, 2023
@czeslavo czeslavo deleted the chore/remove-todo branch January 18, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestDeployAllInOneDBLESSGateway does not verify admission webhook works
2 participants