Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(konnect): push config to konnect #3418

Closed
wants to merge 18 commits into from

Conversation

czeslavo
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 73.8% // Head: 73.4% // Decreases project coverage by -0.5% ⚠️

Coverage data is based on head (32778ac) compared to base (eb0de86).
Patch coverage: 55.7% of modified lines in pull request are covered.

❗ Current head 32778ac differs from pull request most recent head a62c8a1. Consider uploading reports for the commit a62c8a1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3418     +/-   ##
=======================================
- Coverage   73.8%   73.4%   -0.5%     
=======================================
  Files        115     115             
  Lines      13971   14077    +106     
=======================================
+ Hits       10318   10337     +19     
- Misses      2994    3069     +75     
- Partials     659     671     +12     
Impacted Files Coverage Δ
internal/cmd/rootcmd/run.go 21.0% <0.0%> (ø)
internal/dataplane/deckgen/generate.go 55.9% <ø> (ø)
internal/adminapi/client.go 41.4% <25.8%> (-14.4%) ⬇️
internal/dataplane/kong_client.go 85.8% <44.4%> (-1.3%) ⬇️
internal/manager/setup.go 50.7% <48.4%> (-3.8%) ⬇️
internal/dataplane/sendconfig/sendconfig.go 73.9% <53.4%> (-4.9%) ⬇️
internal/manager/utils/kongconfig/root.go 50.0% <60.0%> (+0.4%) ⬆️
internal/admission/server.go 42.0% <76.9%> (+1.1%) ⬆️
internal/manager/config_validation.go 88.6% <85.0%> (-11.4%) ⬇️
internal/dataplane/sendconfig/kong.go 76.3% <100.0%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czeslavo czeslavo marked this pull request as ready for review January 24, 2023 13:08
@czeslavo czeslavo requested a review from a team as a code owner January 24, 2023 13:08
@czeslavo czeslavo marked this pull request as draft January 24, 2023 13:08
@czeslavo czeslavo force-pushed the poc/push-config-to-konnect branch 2 times, most recently from 222da71 to 32778ac Compare January 30, 2023 18:15
@czeslavo czeslavo closed this Feb 7, 2023
@czeslavo czeslavo deleted the poc/push-config-to-konnect branch February 13, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant