Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(konnect): add manifests for konnect config variant #3448

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Jan 30, 2023

What this PR does / why we need it:

It introduces a new variant of deployment: dbless-konnect. It also ships with a specific to it debug configuration to work with Skaffold.

The way Konnect integration will be configured is:

  • CONTROLLER_KONNECT_SYNC_ENABLED feature flag
  • konnect-config ConfigMap (allows setting Konnect specific env variables: CONTROLLER_KONNECT_RUNTIME_GROUP (required) and CONTROLLER_KONNECT_ADDRESS (optional)
  • konnect-client-tls Secret (to pass TLS certs needed to authenticate with Koko)

Which issue this PR fixes:

Part of #3437.

Special notes for your reviewer:

It's adding manifests even though there's no code merged to handle the configuration added yet. It's going to be added soon (#3418).

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 73.7% // Head: 73.7% // Increases project coverage by +0.0% 🎉

Coverage data is based on head (aa91bae) compared to base (a91d35f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3448   +/-   ##
=====================================
  Coverage   73.7%   73.7%           
=====================================
  Files        115     115           
  Lines      13971   13971           
=====================================
+ Hits       10302   10308    +6     
+ Misses      3006    3002    -4     
+ Partials     663     661    -2     
Impacted Files Coverage Δ
...nternal/controllers/gateway/udproute_controller.go 69.5% <0.0%> (-2.2%) ⬇️
...ternal/controllers/gateway/httproute_controller.go 58.5% <0.0%> (-0.2%) ⬇️
...nternal/controllers/gateway/tcproute_controller.go 72.0% <0.0%> (+2.0%) ⬆️
...nternal/controllers/gateway/tlsroute_controller.go 73.4% <0.0%> (+2.0%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czeslavo czeslavo self-assigned this Jan 30, 2023
@czeslavo czeslavo added this to the KIC v2.9.0 milestone Jan 30, 2023
Makefile Outdated Show resolved Hide resolved
@rainest rainest merged commit 2d87885 into main Jan 30, 2023
@rainest rainest deleted the konnect-config branch January 30, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants