test: Conformance tests flakiness fix

[mlavacca]

What this PR does / why we need it:

Which issue this PR fixes:

Fixes #2939

Special notes for your reviewer:

How the lack of flakiness has been proven:

• enabling up to initially 20, then 100, and finally 500 subsequent runs of conformance tests (109ac08)
• three different runs with these numbers:
  • 20 runs completed successfully: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/4052876746/jobs/6972833107
  • 100 runs completed successfully: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/4053635300/jobs/6974483236
  • 136 runs completed successfully: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/4056394996/jobs/6980848816. The 500-runs setup did not complete, as GH stopped the job after 6 hours of execution.

No flaky test has been observed in 256 runs. Note that every conformance test run was executed in a fresh cluster, with no influence coming from the previous iterations.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

• [ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

[codecov]

Codecov Report

Base: 73.8% // Head: 73.9% // Increases project coverage by +0.1% 🎉

Coverage data is based on head (7e5ba8f) compared to base (3e174e8).
Patch coverage: 100.0% of modified lines in pull request are covered.

❗ Current head 7e5ba8f differs from pull request most recent head 68fc2aa. Consider uploading reports for the commit 68fc2aa to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #3451     +/-   ##
=======================================
+ Coverage   73.8%   73.9%   +0.1%     
=======================================
  Files        115     118      +3     
  Lines      13971   13986     +15     
=======================================
+ Hits       10313   10348     +35     
+ Misses      2999    2978     -21     
- Partials     659     660      +1     

Impacted Files	Coverage Δ
...ternal/controllers/gateway/httproute_controller.go	69.7% <100.0%> (+9.6%)	⬆️
internal/adminapi/client.go	13.3% <0.0%> (-42.5%)	⬇️
internal/manager/config_validation.go	90.6% <0.0%> (-9.4%)	⬇️
...nternal/controllers/gateway/tlsroute_controller.go	71.4% <0.0%> (-2.1%)	⬇️
internal/manager/setup.go	52.6% <0.0%> (-1.9%)	⬇️
internal/manager/run.go	45.6% <0.0%> (-0.4%)	⬇️
internal/dataplane/kong_client.go	87.1% <0.0%> (ø)
internal/util/test/controller_manager.go	59.3% <0.0%> (ø)
internal/manager/utils/kongconfig/root.go	49.5% <0.0%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mlavacca]

Details about how the lack of flakiness has been verified in the PR description ☝️

[pmalek]

🎖️ 👍

One question though left in review and one suggestion: can we change the PR title to be more specific and adhere to conventional commits with prefix and all that? 🙏

[pmalek]

Please just make sure the PR title and commit message are renamed to follow conventional commits

[mlavacca]

The rebase invalidated your review, PTAL @pmalek