Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update running status of KIC node to Konnect #3533

Merged
merged 8 commits into from
Feb 14, 2023

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Feb 10, 2023

What this PR does / why we need it:

update status of KIC node in konnect. It receives the status of translating k8s objects and applying kong configurations, and calculate the status of KIC node, then report the status to konnect.

Which issue this PR fixes:

fixes #3515
Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner February 10, 2023 10:01
@randmonkey randmonkey self-assigned this Feb 10, 2023
@randmonkey randmonkey marked this pull request as draft February 10, 2023 10:02
@randmonkey randmonkey added this to the KIC v2.9.0 milestone Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 72.4% // Head: 72.1% // Decreases project coverage by -0.3% ⚠️

Coverage data is based on head (7bcd529) compared to base (ec17ebc).
Patch coverage: 18.1% of modified lines in pull request are covered.

❗ Current head 7bcd529 differs from pull request most recent head bfde4d3. Consider uploading reports for the commit bfde4d3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3533     +/-   ##
=======================================
- Coverage   72.4%   72.1%   -0.3%     
=======================================
  Files        125     126      +1     
  Lines      14457   14531     +74     
=======================================
+ Hits       10474   10488     +14     
- Misses      3316    3376     +60     
  Partials     667     667             
Impacted Files Coverage Δ
internal/adminapi/konnect.go 0.0% <ø> (ø)
internal/konnect/node_agent.go 0.0% <0.0%> (ø)
internal/manager/run.go 42.5% <0.0%> (-3.0%) ⬇️
internal/dataplane/config_status.go 11.1% <11.1%> (ø)
internal/dataplane/kong_client.go 83.0% <79.1%> (-1.0%) ⬇️
internal/manager/config.go 94.3% <100.0%> (+<0.1%) ⬆️
...nternal/controllers/gateway/udproute_controller.go 69.5% <0.0%> (-2.2%) ⬇️
internal/dataplane/parser/parser.go 90.7% <0.0%> (-0.9%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@randmonkey randmonkey force-pushed the feat/update_kic_status_to_konnect branch from 53d815c to f9234dd Compare February 13, 2023 07:00
@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 13, 2023
@randmonkey randmonkey force-pushed the feat/update_kic_status_to_konnect branch 2 times, most recently from ffb4fb0 to 2850a4e Compare February 13, 2023 07:11
@randmonkey randmonkey changed the title [WIP] update running status of KIC node to Konnect feat: update running status of KIC node to Konnect Feb 13, 2023
@randmonkey randmonkey marked this pull request as ready for review February 13, 2023 07:45
internal/konnect/node_agent.go Outdated Show resolved Hide resolved
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
internal/konnect/node_agent.go Outdated Show resolved Hide resolved
internal/konnect/node_agent.go Outdated Show resolved Hide resolved
internal/konnect/node_agent.go Outdated Show resolved Hide resolved
@randmonkey randmonkey force-pushed the feat/update_kic_status_to_konnect branch from 9db5099 to 3a476b7 Compare February 14, 2023 09:18
@randmonkey randmonkey enabled auto-merge (squash) February 14, 2023 09:54
czeslavo
czeslavo previously approved these changes Feb 14, 2023
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
internal/dataplane/kong_client.go Show resolved Hide resolved
internal/konnect/node_agent.go Outdated Show resolved Hide resolved
@randmonkey randmonkey force-pushed the feat/update_kic_status_to_konnect branch from 7bcd529 to 2356d5a Compare February 14, 2023 12:39
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
internal/konnect/node_agent.go Outdated Show resolved Hide resolved
internal/manager/run.go Outdated Show resolved Hide resolved
@pmalek pmalek added area/konnect Issues and PRs related to Konnect area/feature New feature or request labels Feb 14, 2023
@randmonkey randmonkey merged commit ea2ed68 into main Feb 14, 2023
@randmonkey randmonkey deleted the feat/update_kic_status_to_konnect branch February 14, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request area/konnect Issues and PRs related to Konnect size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KIC-Konnect: update status of KIC node
3 participants