feat(konnect): account for config sync failures in reported node status #4029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E (targeted) tests were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5006144559 |
czeslavo
force-pushed
the
feat/konnect-out-of-sync
branch
3 times, most recently
from
6baa1ee
to
1c1d482
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4029 +/- ##
=======================================
+ Coverage 59.6% 59.9% +0.3%
=======================================
Files 149 149
Lines 16434 16462 +28
=======================================
+ Hits 9806 9873 +67
+ Misses 5995 5960 -35
+ Partials 633 629 -4
☔ View full report in Codecov by Sentry. |
czeslavo
force-pushed
the
feat/konnect-out-of-sync
branch
3 times, most recently
from
5021770
to
9aa4cd7
Compare
czeslavo
added
area/feature
czeslavo
changed the title
czeslavo
force-pushed
the
feat/konnect-out-of-sync
branch
3 times, most recently
from
667eff3
to
be6f805
Compare
czeslavo
changed the title
|
E2E (targeted) tests were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5012901967 |
It extends the config sync status reported to Konnect's Node API with values that take into account failures of syncing configuration with Konnect RG, effectively extending it with three new values (on the API surface level): - INGRESS_CONTROLLER_STATE_OPERATIONAL_KONNECT_OUT_OF_SYNC - INGRESS_CONTROLLER_STATE_PARTIAL_CONFIG_FAIL_KONNECT_OUT_OF_SYNC - INGRESS_CONTROLLER_STATE_INOPERABLE_KONNECT_OUT_OF_SYNC There's no strict contract for allowed values on the API level, however, there's an implicit contract between KIC and Konnect UI that directly consumes the Node object, therefore we're keeping the old values unchanged to make them backward-compatible.
czeslavo
force-pushed
the
feat/konnect-out-of-sync
branch
from
be6f805
to
1dd0725
Compare
pmalek
reviewed
May 18, 2023
czeslavo
force-pushed
the
feat/konnect-out-of-sync
branch
from
3c1b059
to
a74a800
Compare
pmalek
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It extends the config sync status reported to Konnect's Node API with values that take into account failures of syncing configuration with Konnect RG, effectively extending it with three new values (on the API surface level):
INGRESS_CONTROLLER_STATE_OPERATIONAL_KONNECT_OUT_OF_SYNCINGRESS_CONTROLLER_STATE_PARTIAL_CONFIG_FAIL_KONNECT_OUT_OF_SYNCINGRESS_CONTROLLER_STATE_INOPERABLE_KONNECT_OUT_OF_SYNCThere's no strict contract for allowed values on the API level, however, there's an implicit contract between KIC and Konnect UI that directly consumes the
Nodeobject, therefore we're keeping the old values unchanged to make them backward-compatible.Which issue this PR fixes:
Internal reference: K8-67.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR