Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(konnect): account for config sync failures in reported node status #4029

Merged
merged 2 commits into from
May 18, 2023
Merged

feat(konnect): account for config sync failures in reported node status #4029

merged 2 commits into from
May 18, 2023

Commits on May 18, 2023

  1. feat(konnect): account for konnect sync failures in reported node status 

    It extends the config sync status reported to Konnect's Node API with values
that take into account failures of syncing configuration with Konnect RG,
effectively extending it with three new values (on the API surface level):

- INGRESS_CONTROLLER_STATE_OPERATIONAL_KONNECT_OUT_OF_SYNC
- INGRESS_CONTROLLER_STATE_PARTIAL_CONFIG_FAIL_KONNECT_OUT_OF_SYNC
- INGRESS_CONTROLLER_STATE_INOPERABLE_KONNECT_OUT_OF_SYNC

There's no strict contract for allowed values on the API level, however,
there's an implicit contract between KIC and Konnect UI that directly consumes
the Node object, therefore we're keeping the old values unchanged to make them
backward-compatible.
    @czeslavo
    czeslavo committed May 18, 2023
    Configuration menu
    Copy the full SHA
    1dd0725 View commit details
    Browse the repository at this point in the history

  2. address review comments

    @czeslavo
    czeslavo committed May 18, 2023
    Configuration menu
    Copy the full SHA
    a74a800 View commit details
    Browse the repository at this point in the history