-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parser) bound v6 targets properly #4391
Conversation
Surround IPv6 Endpoint addresses with brackets when generating a target. Without these, the target port suffix parses as part of the address and assigns an incorrect address and (default) port.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4391 +/- ##
=======================================
- Coverage 66.5% 66.3% -0.3%
=======================================
Files 158 158
Lines 18556 18555 -1
=======================================
- Hits 12347 12302 -45
- Misses 5456 5510 +54
+ Partials 753 743 -10
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally good, but can we add some unit tests for the fix?
fb2afa9
What this PR does / why we need it:
Surround IPv6 Endpoint addresses with brackets when generating a target. Without these, the target port suffix parses as part of the address and assigns an incorrect address and (default) port.
Which issue this PR fixes:
Fixes #4369. Thanks @pnathan for locating the problem section of the parser code for us!
Special notes for your reviewer:
CI doesn't do v6-only at present. We should maybe consider that as a nightly test. There are quite possibly other v6-only problems. We don't have the scaffolding to actually do that yet though, so spot testing it is!
Local testing using https://kind.sigs.k8s.io/docs/user/configuration/#ip-family was to confirm via the stock image:
After putting an image with this change in place, no more errant 80 octet, or whatever you call v6 segments:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR