-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump deck to handle Certificate updates in Konnect sync properly #4400
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4400 +/- ##
=======================================
- Coverage 65.9% 65.9% -0.1%
=======================================
Files 158 158
Lines 18274 18279 +5
=======================================
- Hits 12058 12048 -10
- Misses 5478 5492 +14
- Partials 738 739 +1
☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.10.x release/2.10.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.10.x
# Create a new branch
git switch --create backport-4400-to-release/2.10.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4b8dc3edee9996c6dd33cdd4aaf80fe9a4539cb9
# Push it to GitHub
git push --set-upstream origin backport-4400-to-release/2.10.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.10.x Then, create a pull request where the |
What this PR does / why we need it:
Bumps deck to a version that fixes #4384 (in this particular commit). Propagates
IsKonnect
flag when creatingdiff.Syncer
.The Certificate update case is now covered in deck's integration tests.
Which issue this PR fixes:
Closes #4384.
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR