Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump deck to handle Certificate updates in Konnect sync properly #4400

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Jul 25, 2023

What this PR does / why we need it:

Bumps deck to a version that fixes #4384 (in this particular commit). Propagates IsKonnect flag when creating diff.Syncer.

The Certificate update case is now covered in deck's integration tests.

Which issue this PR fixes:

Closes #4384.

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo changed the title fix: bump deck to v1.24.0 to handle Certificate updates in Konnect sync properly fix: bump deck to handle Certificate updates in Konnect sync properly Jul 25, 2023
@czeslavo czeslavo added area/konnect Issues and PRs related to Konnect fix backport release/2.10.x labels Jul 25, 2023
@czeslavo czeslavo marked this pull request as ready for review July 25, 2023 10:58
@czeslavo czeslavo requested a review from a team as a code owner July 25, 2023 10:58
@czeslavo czeslavo added this to the KIC v2.11.0 milestone Jul 25, 2023
@czeslavo czeslavo self-assigned this Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 100.0% and project coverage change: -0.1% ⚠️

Comparison is base (5731f92) 65.9% compared to head (ca26a55) 65.9%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4400     +/-   ##
=======================================
- Coverage   65.9%   65.9%   -0.1%     
=======================================
  Files        158     158             
  Lines      18274   18279      +5     
=======================================
- Hits       12058   12048     -10     
- Misses      5478    5492     +14     
- Partials     738     739      +1     
Files Changed Coverage Δ
internal/dataplane/sendconfig/dbmode.go 72.2% <100.0%> (+2.8%) ⬆️
internal/dataplane/sendconfig/strategy.go 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo enabled auto-merge (squash) July 25, 2023 11:25
@czeslavo czeslavo merged commit 4b8dc3e into main Jul 25, 2023
31 checks passed
@czeslavo czeslavo deleted the fix-4384 branch July 25, 2023 11:25
@github-actions
Copy link

The backport to release/2.10.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.10.x release/2.10.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.10.x
# Create a new branch
git switch --create backport-4400-to-release/2.10.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4b8dc3edee9996c6dd33cdd4aaf80fe9a4539cb9
# Push it to GitHub
git push --set-upstream origin backport-4400-to-release/2.10.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.10.x

Then, create a pull request where the base branch is release/2.10.x and the compare/head branch is backport-4400-to-release/2.10.x.

czeslavo added a commit that referenced this pull request Jul 25, 2023
Bumps deck to a version that fixes #4384 (in this particular commit). Propagates IsKonnect flag when creating diff.Syncer.

(cherry picked from commit 4b8dc3e)
czeslavo added a commit that referenced this pull request Jul 25, 2023
Bumps deck to a version that fixes #4384 (in this particular commit). Propagates IsKonnect flag when creating diff.Syncer.

(cherry picked from commit 4b8dc3e)
czeslavo added a commit that referenced this pull request Jul 25, 2023
…4401)

Bumps deck to a version that fixes #4384 (in this particular commit). Propagates IsKonnect flag when creating diff.Syncer.

(cherry picked from commit 4b8dc3e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KIC fails to sync with Konnect when updating Certificate
2 participants