Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump deck to handle Certificate updates in Konnect sync, prepare 2.10.4 #4401

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Jul 25, 2023

Backports #4400 to release/2.10.x and prepares 2.10.4 release.

It has changes in the manifests due to a cascading update of go-kong which introduced a new field in v0.43.0: Kong/go-kong#331.

(cherry picked from commit 4b8dc3e)

@czeslavo czeslavo added area/konnect Issues and PRs related to Konnect fix labels Jul 25, 2023
@czeslavo czeslavo added this to the KIC v2.10.0 milestone Jul 25, 2023
@czeslavo czeslavo self-assigned this Jul 25, 2023
@czeslavo czeslavo changed the title fix: bump deck to handle Certificate updates in Konnect sync, prepare 2.10.4 release fix: bump deck to handle Certificate updates in Konnect sync, prepare 2.10.4 Jul 25, 2023
@czeslavo czeslavo added the ci/run-e2e Trigger e2e test run from PR label Jul 25, 2023
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5656268420

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Jul 25, 2023
Bumps deck to a version that fixes #4384 (in this particular commit). Propagates IsKonnect flag when creating diff.Syncer.

(cherry picked from commit 4b8dc3e)
@czeslavo czeslavo force-pushed the backport-4400-to-release/2.10.x branch from 94c7c31 to 1f0dcba Compare July 25, 2023 12:04
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 100.0% and no project coverage change.

Comparison is base (00890a5) 61.0% compared to head (1f0dcba) 61.1%.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/2.10.x   #4401   +/-   ##
==============================================
  Coverage            61.0%   61.1%           
==============================================
  Files                 152     152           
  Lines               16954   16959    +5     
==============================================
+ Hits                10348   10367   +19     
+ Misses               5966    5953   -13     
+ Partials              640     639    -1     
Files Changed Coverage Δ
internal/dataplane/sendconfig/dbmode.go 72.2% <100.0%> (+2.8%) ⬆️
internal/dataplane/sendconfig/strategy.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo marked this pull request as ready for review July 25, 2023 12:09
@czeslavo czeslavo requested a review from a team as a code owner July 25, 2023 12:09
@czeslavo czeslavo requested a review from pmalek July 25, 2023 12:38
@pmalek pmalek added the dependencies Pull requests that update a dependency file label Jul 25, 2023
@czeslavo czeslavo merged commit 72cd759 into release/2.10.x Jul 25, 2023
31 checks passed
@czeslavo czeslavo deleted the backport-4400-to-release/2.10.x branch July 25, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/konnect Issues and PRs related to Konnect dependencies Pull requests that update a dependency file fix size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants