Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consumer group): allow assigning plugins to consumer groups #4452

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Aug 3, 2023

What this PR does / why we need it:

It allows specifying plugins for consumer groups via annotation, a subset of plugins is supported this way by Gateway https://github.com/Kong/kong-ee/pull/5291. Adjust integration test - introduce proper testing scenario (it checks actual behavior now).

Which issue this PR fixes:

This is part of #3728

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@programmer04 programmer04 added area/feature New feature or request work in progress Work In Progress do not merge let the author merge this, don't merge for them. area/CRD Changes in existing CRDs or introduction of new ones labels Aug 3, 2023
@programmer04 programmer04 added this to the KIC v2.11.0 milestone Aug 3, 2023
@programmer04 programmer04 self-assigned this Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 76.9% and project coverage change: -0.3% ⚠️

Comparison is base (7df5df2) 67.9% compared to head (2e01822) 67.7%.

❗ Current head 2e01822 differs from pull request most recent head 37818c1. Consider uploading reports for the commit 37818c1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4452     +/-   ##
=======================================
- Coverage   67.9%   67.7%   -0.3%     
=======================================
  Files        161     161             
  Lines      18817   18839     +22     
=======================================
- Hits       12788   12756     -32     
- Misses      5270    5323     +53     
- Partials     759     760      +1     
Files Changed Coverage Δ
internal/dataplane/deckgen/deckgen.go 60.3% <0.0%> (-3.7%) ⬇️
internal/dataplane/kongstate/kongstate.go 72.7% <81.2%> (+0.4%) ⬆️
internal/dataplane/parser/parser.go 84.2% <100.0%> (-0.8%) ⬇️
internal/util/relations.go 100.0% <100.0%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
@programmer04 programmer04 removed do not merge let the author merge this, don't merge for them. work in progress Work In Progress labels Aug 8, 2023
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Aug 8, 2023
@programmer04 programmer04 added the ci/run-nightly Run nightly Kong image integration tests label Aug 8, 2023
@team-k8s-bot team-k8s-bot removed the ci/run-nightly Run nightly Kong image integration tests label Aug 8, 2023
@programmer04 programmer04 added the work in progress Work In Progress label Aug 8, 2023
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Aug 9, 2023
@Kong Kong deleted a comment from team-k8s-bot Aug 9, 2023
@Kong Kong deleted a comment from team-k8s-bot Aug 9, 2023
@programmer04 programmer04 added the ci/run-nightly Run nightly Kong image integration tests label Aug 9, 2023
@team-k8s-bot
Copy link
Collaborator

Integration (targeted) tests with KIND-based cluster and latest images were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5806126819

@team-k8s-bot team-k8s-bot removed the ci/run-nightly Run nightly Kong image integration tests label Aug 9, 2023
@Kong Kong deleted a comment from team-k8s-bot Aug 9, 2023
@Kong Kong deleted a comment from team-k8s-bot Aug 9, 2023
@programmer04 programmer04 removed the work in progress Work In Progress label Aug 9, 2023
@programmer04 programmer04 marked this pull request as ready for review August 9, 2023 07:51
@programmer04 programmer04 requested a review from a team as a code owner August 9, 2023 07:51
@programmer04 programmer04 enabled auto-merge (squash) August 9, 2023 07:51
czeslavo
czeslavo previously approved these changes Aug 9, 2023
@randmonkey
Copy link
Contributor

@programmer04 please re-run make lint to pass the linting check.

Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
@programmer04 programmer04 merged commit 6c08f89 into main Aug 9, 2023
30 checks passed
@programmer04 programmer04 deleted the cg-plugins branch August 9, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CRD Changes in existing CRDs or introduction of new ones area/feature New feature or request size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants