-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consumer group): allow assigning plugins to consumer groups #4452
Conversation
72a3ed7
to
ba0c664
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4452 +/- ##
=======================================
- Coverage 67.9% 67.7% -0.3%
=======================================
Files 161 161
Lines 18817 18839 +22
=======================================
- Hits 12788 12756 -32
- Misses 5270 5323 +53
- Partials 759 760 +1
☔ View full report in Codecov by Sentry. |
e05c8a4
to
fb06670
Compare
fb06670
to
c4646ff
Compare
c4646ff
to
b8ff0e7
Compare
b8ff0e7
to
651b9b1
Compare
Integration (targeted) tests with KIND-based cluster and latest images were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5806126819 |
@programmer04 please re-run |
Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
2e01822
to
37818c1
Compare
What this PR does / why we need it:
It allows specifying plugins for consumer groups via annotation, a subset of plugins is supported this way by Gateway https://github.com/Kong/kong-ee/pull/5291. Adjust integration test - introduce proper testing scenario (it checks actual behavior now).
Which issue this PR fixes:
This is part of #3728
Special notes for your reviewer:
deck
directly frommain
branch to include unreleased yet changes introduced in feat: support scoping plugins to consumer-groups deck#959TestConsumerGroup
is always skipped for nonenterprise deployments and enterprise ones that use Kong Gateway< 3.4
(unreleased yet). HenceTestConsumerGroup
for this PR is skipped because a used image is3.3
see:- integration-tests / enterprise-postgres
- integration-tests / enterprise-dbless
But you can check that integration test
TestConsumerGroup
passes (is not skipped) by inspecting the result of a run of on-demand run integration tests (triggered with the labelci/run-nightly
). They uses latest Kong Gateway image - feat(consumer group): allow assigning plugins to consumer groups #4452 (comment):- integration-tests-enterprise-postgres-nightly
- integration-tests-enterprise-dbless-nightly
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR