-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deck content to dbless converter #4459
Conversation
8dbdb69
to
84e7c30
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4459 +/- ##
=======================================
- Coverage 67.7% 67.6% -0.1%
=======================================
Files 161 161
Lines 18840 18832 -8
=======================================
- Hits 12758 12746 -12
- Misses 5319 5325 +6
+ Partials 763 761 -2
☔ View full report in Codecov by Sentry. |
84e7c30
to
b9628da
Compare
b9628da
to
99eb06d
Compare
99eb06d
to
07ada11
Compare
07ada11
to
011aabb
Compare
What is the base of this change, that is is it mentioned somewhere in spec or docs? 🤔 |
In the source code that I referred to in the description (I enhanced it) @pmalek. In the first implementation #4453, @czeslavo was misguided. I discovered it during work on #4452, we looked into the Gateway source and proposed this PR. Unfortunately, Kong Gateway doesn't have proper documentation for dbless declarative config format |
What this PR does / why we need it:
Which issue this PR fixes:
Continuation of #4453