Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deck content to dbless converter #4459

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Aug 7, 2023

What this PR does / why we need it:

  • Configuration for which IDs are filled, but names are not is invalid, so the converter should not panic
  • Use plugins[].consumer_group (new method of working with consumer groups and plugins for Gateway >= 3.4) instead of consumer_group_plugins (obsolete - used by old implementation of consumer groups Gateway < 3.4, used by mistake in the first implementation), otherwise Gateway rejects config

Which issue this PR fixes:

Continuation of #4453

@programmer04 programmer04 added this to the KIC v2.11.0 milestone Aug 7, 2023
@programmer04 programmer04 self-assigned this Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 100.0% and project coverage change: -0.1% ⚠️

Comparison is base (9dfe212) 67.7% compared to head (011aabb) 67.6%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4459     +/-   ##
=======================================
- Coverage   67.7%   67.6%   -0.1%     
=======================================
  Files        161     161             
  Lines      18840   18832      -8     
=======================================
- Hits       12758   12746     -12     
- Misses      5319    5325      +6     
+ Partials     763     761      -2     
Files Changed Coverage Δ
internal/dataplane/kongstate/kongstate.go 72.3% <ø> (ø)
internal/dataplane/sendconfig/inmemory_schema.go 100.0% <100.0%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 7, 2023
@programmer04 programmer04 changed the title fix: deck content to dbless converter for empty names fix: deck content to dbless converter Aug 7, 2023
@programmer04 programmer04 marked this pull request as ready for review August 7, 2023 14:15
@programmer04 programmer04 requested a review from a team as a code owner August 7, 2023 14:15
@pmalek
Copy link
Member

pmalek commented Aug 7, 2023

What is the base of this change, that is is it mentioned somewhere in spec or docs? 🤔

@programmer04
Copy link
Member Author

In the source code that I referred to in the description (I enhanced it) @pmalek. In the first implementation #4453, @czeslavo was misguided. I discovered it during work on #4452, we looked into the Gateway source and proposed this PR. Unfortunately, Kong Gateway doesn't have proper documentation for dbless declarative config format

@programmer04 programmer04 merged commit a6d3159 into main Aug 7, 2023
38 checks passed
@programmer04 programmer04 deleted the fix-converter-panics branch August 7, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants