-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: introduce deck content to dbless config converter #4453
Conversation
3bb1712
to
93af96e
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4453 +/- ##
=======================================
- Coverage 67.5% 66.0% -1.5%
=======================================
Files 160 156 -4
Lines 18804 18722 -82
=======================================
- Hits 12699 12372 -327
- Misses 5343 5631 +288
+ Partials 762 719 -43
☔ View full report in Codecov by Sentry. |
93af96e
to
fbcd932
Compare
ec436dd
to
2546178
Compare
2546178
to
92f9ffa
Compare
3936a50
to
25609f7
Compare
What this PR does / why we need it:
Introduces
ContentToDBLessConfigConverter
used byUpdateStrategyInMemory
to adapt decK'sfile.Content
to match DBLess schema constraints.It extracts the already existing conversions from
UpdateStrategyInMemory
(droppingInfo
field, cleaning up nulls in plugins' configs), and also adds cleanups forConsumerGroups
related fields (droppingPlugins[i].ConsumerGroup
,Consumers[i].Group
,ConsumerGroups[i].Plugins
,ConsumerGroups[i].Consumers
, filling relationships).Also adds an example config for
ConsumerGroup
.Which issue this PR fixes:
Fixes #4448.