fix: disable Kong(Cluster)Plugin Programmed status #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable the Kong(Cluster)Plugin programmed condition. This caused a bug in multi-class environments. Add a TODO explaining the issue.
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6006524843 |
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6006527185 |
rainest
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4584 +/- ##
=======================================
- Coverage 68.3% 68.1% -0.3%
=======================================
Files 162 162
Lines 19030 18992 -38
=======================================
- Hits 13014 12945 -69
- Misses 5245 5291 +46
+ Partials 771 756 -15
☔ View full report in Codecov by Sentry. |
randmonkey
previously approved these changes
Aug 29, 2023
pmalek
previously approved these changes
Aug 29, 2023
pmalek
changed the title
pmalek
force-pushed
the
fix/kongplugin-status
branch
from
c8d0f52
to
e44bcf6
Compare
pmalek
approved these changes
Aug 29, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 29, 2023
* fix(crds) disable KongPlugin programmed condition Disable the Kong(Cluster)Plugin programmed condition. This caused a bug in multi-class environments. Add a TODO explaining the issue. * chore(*) make generate * chore(doc): add changelog entry for 2.11.1 --------- Co-authored-by: Patryk Małek <patryk.malek@konghq.com> (cherry picked from commit 2bafc2d)
pmalek
added a commit
that referenced
this pull request
Aug 29, 2023
… status (#4585) * fix: disable Kong(Cluster)Plugin Programmed status (#4584) * fix(crds) disable KongPlugin programmed condition Disable the Kong(Cluster)Plugin programmed condition. This caused a bug in multi-class environments. Add a TODO explaining the issue. * chore(*) make generate * chore(doc): add changelog entry for 2.11.1 --------- Co-authored-by: Patryk Małek <patryk.malek@konghq.com> (cherry picked from commit 2bafc2d) * chore: trigger CI --------- Co-authored-by: Travis Raines <571832+rainest@users.noreply.github.com> Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Disables Kong(Cluster)Plugin status updates. Add TODOs for the relevant bug.
Which issue this PR fixes:
Multiple KIC instances in the same cluster will fight over plugin statuses because plugins have no class. We don't want them to have class, unless they're global.
Special notes for your reviewer:
Double duty as a release PR for #4582. AFAIK we're no longer doing updates other than the fixes themselves since we're now using relative tags, so the manifests remain unchanged.
A proper fix for this probably requires breaking out the plugin controller, so I think we want a hotfix for now. The feature isn't critical.
See https://github.com/Kong/kubernetes-ingress-controller/pull/4412/files for the original change. There are some other struct changes there, but AFAIK disabling the reconciler bit alone avoids the issue.
Didn't want to send this to main and backport since it touches generated code. I think we need to cherry-pick the first commit and generate separately if we don't have a more complete fix in for 2.12.There haven't been changes to the generated controllers since 2.11.0, so this one's actually fine.PR Readiness Checklist:
Complete these before marking the PR as
ready to review:theSeparately to main only. chore(doc) add 2.11.1 changelog #4583CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR