Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove everything related obsolete global KongPlugins #4737

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Sep 27, 2023

What this PR does / why we need it:

KongClusterPlugin supports the label global: true, see the docs and it is not changed.

For a long time (since KIC v0.10.0) for KongPlugin with the label global: true KIC logs a warning about unsupporting. This PR gets rid of everything related to the support of label global for KongPlugin, including a warning.

Which issue this PR fixes:

Closes #3873

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@programmer04 programmer04 added area/debt area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. ci/run-e2e Trigger e2e test run from PR labels Sep 27, 2023
@programmer04 programmer04 added this to the KIC v3.0.0 milestone Sep 27, 2023
@programmer04 programmer04 self-assigned this Sep 27, 2023
@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Sep 27, 2023
@programmer04 programmer04 added the do not merge let the author merge this, don't merge for them. label Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (95b0447) 67.9% compared to head (59e302b) 67.8%.
Report is 1 commits behind head on main.

❗ Current head 59e302b differs from pull request most recent head 90347c6. Consider uploading reports for the commit 90347c6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4737     +/-   ##
=======================================
- Coverage   67.9%   67.8%   -0.1%     
=======================================
  Files        165     165             
  Lines      19291   19208     -83     
=======================================
- Hits       13102   13029     -73     
+ Misses      5420    5416      -4     
+ Partials     769     763      -6     
Files Coverage Δ
internal/dataplane/kongstate/kongstate.go 79.9% <ø> (+5.8%) ⬆️
internal/store/store.go 61.7% <ø> (-0.1%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@programmer04 programmer04 changed the title chore: remove everything related obsolete global plugins chore: remove everything related obsolete global KongPlugins Sep 28, 2023
@pull-request-size pull-request-size bot added size/M and removed size/L labels Sep 28, 2023
@programmer04 programmer04 removed the do not merge let the author merge this, don't merge for them. label Sep 28, 2023
@programmer04 programmer04 marked this pull request as ready for review September 28, 2023 11:10
@programmer04 programmer04 requested a review from a team as a code owner September 28, 2023 11:10
@Kong Kong deleted a comment from team-k8s-bot Sep 28, 2023
@programmer04 programmer04 added the ci/run-e2e Trigger e2e test run from PR label Sep 28, 2023
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6338093891

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Sep 28, 2023
@programmer04 programmer04 enabled auto-merge (squash) September 28, 2023 11:11
@programmer04 programmer04 merged commit 9c19f60 into main Sep 28, 2023
192 of 195 checks passed
@programmer04 programmer04 deleted the rm-global-plugins branch September 28, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/debt area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unsupported global plugins
3 participants