Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove feature gate CombinedRoutes #4749

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Sep 28, 2023

What this PR does / why we need it:

CombinedRoutes graduated to be always enabled and not configurable, remove the feature gate, all code related to handling old behavior, and adjust tests.

Which issue this PR fixes:

Closes #3131

Special notes for your reviewer:

Golden tests **/combined-routes-off_golden.yaml have been removed, because now it can't be disabled.
As I checked no changes are required in Helm charts.
Please point me in case of miss a place where I should make an update.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@programmer04 programmer04 added the ci/run-e2e Trigger e2e test run from PR label Sep 28, 2023
@programmer04 programmer04 added this to the KIC v3.1.0 milestone Sep 28, 2023
@programmer04 programmer04 requested a review from a team as a code owner September 28, 2023 10:14
@programmer04 programmer04 self-assigned this Sep 28, 2023
@programmer04 programmer04 modified the milestones: KIC v3.1.0, KIC v3.0.0 Sep 28, 2023
@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Sep 28, 2023
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6337549972

@programmer04 programmer04 enabled auto-merge (squash) September 28, 2023 10:16
@Kong Kong deleted a comment from team-k8s-bot Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (95b0447) 67.9% compared to head (f790020) 67.7%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4749     +/-   ##
=======================================
- Coverage   67.9%   67.7%   -0.2%     
=======================================
  Files        165     165             
  Lines      19291   19094    -197     
=======================================
- Hits       13102   12931    -171     
+ Misses      5420    5400     -20     
+ Partials     769     763      -6     
Files Coverage Δ
internal/dataplane/kongstate/kongstate.go 74.9% <100.0%> (+0.8%) ⬆️
internal/dataplane/parser/parser.go 83.3% <100.0%> (-1.1%) ⬇️
internal/dataplane/parser/translate_ingress.go 96.4% <ø> (+0.4%) ⬆️
internal/manager/featuregates/feature_gates.go 100.0% <100.0%> (ø)
internal/dataplane/parser/translate_httproute.go 73.5% <84.2%> (-4.1%) ⬇️
internal/admission/validation/ingress/ingress.go 0.0% <0.0%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, it's good to see all this code going away :)

@programmer04 programmer04 merged commit 23de4f5 into main Sep 28, 2023
203 of 216 checks passed
@programmer04 programmer04 deleted the rm-CombinedRoutes branch September 28, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove non-combined route generation
3 participants