feat: provide Kong admin token via file #4808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests and checks.
Updated changelog.
randmonkey
reviewed
Oct 11, 2023
There was a problem hiding this comment.
As the linter suggests, please add description of the new flag in docs/cli-arguments.md: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6479011252/job/17591921676?pr=4808
|
To make the linter and verify CI step happy, you'll have to run the CLI reference generation to include the added flag: |
Co-authored-by: Tao Yi <richardyi0110@hotmail.com>
Updated cli-arguments.md
Done, and sorry for missing it. |
czeslavo
reviewed
Oct 11, 2023
programmer04
changed the title
programmer04
changed the title
czeslavo
reviewed
Oct 11, 2023
Feedback from PR review.
Review from comments.
Missing from the commit.
czeslavo
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When deploying Kong Enterprise in Kubernetes we need another option to secure the Kong admin token. The existing feature to provide the kong-admin-token via the environment variable CONTROLLER_KONG_ADMIN_TOKEN which can be backed as a Kubernetes secret does not fit for us.
Which issue this PR fixes:
Providing Kong admin token via file #4789
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR