-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provide Kong admin token via file #4808
Conversation
Add tests and checks.
Updated changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the linter suggests, please add description of the new flag in docs/cli-arguments.md
: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6479011252/job/17591921676?pr=4808
To make the linter and verify CI step happy, you'll have to run the CLI reference generation to include the added flag:
|
Co-authored-by: Tao Yi <richardyi0110@hotmail.com>
Updated cli-arguments.md
Done, and sorry for missing it. |
Feedback from PR review.
Review from comments.
Missing from the commit.
What this PR does / why we need it:
When deploying Kong Enterprise in Kubernetes we need another option to secure the Kong admin token. The existing feature to provide the kong-admin-token via the environment variable CONTROLLER_KONG_ADMIN_TOKEN which can be backed as a Kubernetes secret does not fit for us.
Which issue this PR fixes:
Providing Kong admin token via file #4789
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR