-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Providing Kong admin token via file #4789
Labels
Comments
ludovic-pourrat
added a commit
to ludovic-pourrat/kubernetes-ingress-controller
that referenced
this issue
Oct 10, 2023
Add the kong-admin-token-file support.
We'll happily accept a patch adding this functionality with two prerequisites:
Feel free to open a PR. |
ludovic-pourrat
added a commit
to ludovic-pourrat/kubernetes-ingress-controller
that referenced
this issue
Oct 10, 2023
ludovic-pourrat
added a commit
to ludovic-pourrat/kubernetes-ingress-controller
that referenced
this issue
Oct 11, 2023
Add tests and checks.
ludovic-pourrat
added a commit
to ludovic-pourrat/kubernetes-ingress-controller
that referenced
this issue
Oct 11, 2023
ludovic-pourrat
added a commit
to ludovic-pourrat/kubernetes-ingress-controller
that referenced
this issue
Oct 11, 2023
Updated changelog.
1 task
ludovic-pourrat
added a commit
to ludovic-pourrat/kubernetes-ingress-controller
that referenced
this issue
Oct 11, 2023
Updated cli-arguments.md
ludovic-pourrat
added a commit
to ludovic-pourrat/kubernetes-ingress-controller
that referenced
this issue
Oct 11, 2023
Feedback from PR review.
ludovic-pourrat
added a commit
to ludovic-pourrat/kubernetes-ingress-controller
that referenced
this issue
Oct 11, 2023
Review from comments.
ludovic-pourrat
added a commit
to ludovic-pourrat/kubernetes-ingress-controller
that referenced
this issue
Oct 11, 2023
Missing from the commit.
ludovic-pourrat
added a commit
to ludovic-pourrat/kubernetes-ingress-controller
that referenced
this issue
Oct 11, 2023
PR merged, many thanks for you prompt and great support ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Problem Statement
When deploying Kong Enterprise in Kubernetes we need another option to secure the Kong admin token. The existing feature to provide the kong-admin-token via the environment variable CONTROLLER_KONG_ADMIN_TOKEN which can be backed as a Kubernetes secret does not fit for us.
Proposed Solution
This feature proposal add the support for the Kong admin token to be provided via a file by leveraging the same feature that Kong supports in the gateway, so to fetch secrets from environment variable suffixed by _FILE.
We this option we can provide the Kong admin token from our vault, by injecting the a file containing the token.
In this proposal a new
kong-admin-token-file
option is added.Additional information
No response
Acceptance Criteria
The text was updated successfully, but these errors were encountered: