Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing Kong admin token via file #4789

Closed
2 tasks done
ludovic-pourrat opened this issue Oct 10, 2023 · 2 comments
Closed
2 tasks done

Providing Kong admin token via file #4789

ludovic-pourrat opened this issue Oct 10, 2023 · 2 comments
Assignees
Labels

Comments

@ludovic-pourrat
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

When deploying Kong Enterprise in Kubernetes we need another option to secure the Kong admin token. The existing feature to provide the kong-admin-token via the environment variable CONTROLLER_KONG_ADMIN_TOKEN which can be backed as a Kubernetes secret does not fit for us.

Proposed Solution

This feature proposal add the support for the Kong admin token to be provided via a file by leveraging the same feature that Kong supports in the gateway, so to fetch secrets from environment variable suffixed by _FILE.
We this option we can provide the Kong admin token from our vault, by injecting the a file containing the token.

In this proposal a new kong-admin-token-file option is added.

Additional information

No response

Acceptance Criteria

  • As a DevOps engineer I should be in position to provide to Kong admin token via a mounted file within the KIC pod.
ludovic-pourrat added a commit to ludovic-pourrat/kubernetes-ingress-controller that referenced this issue Oct 10, 2023
Add the kong-admin-token-file support.
@mflendrich
Copy link
Member

Hi @ludovic-pourrat

We'll happily accept a patch adding this functionality with two prerequisites:

  • that validations exist (that the direct literal value setting & the filename setting are mutually exclusive)
  • that the PR includes unit tests

Feel free to open a PR.

ludovic-pourrat added a commit to ludovic-pourrat/kubernetes-ingress-controller that referenced this issue Oct 10, 2023
ludovic-pourrat added a commit to ludovic-pourrat/kubernetes-ingress-controller that referenced this issue Oct 11, 2023
ludovic-pourrat added a commit to ludovic-pourrat/kubernetes-ingress-controller that referenced this issue Oct 11, 2023
ludovic-pourrat added a commit to ludovic-pourrat/kubernetes-ingress-controller that referenced this issue Oct 11, 2023
ludovic-pourrat added a commit to ludovic-pourrat/kubernetes-ingress-controller that referenced this issue Oct 11, 2023
ludovic-pourrat added a commit to ludovic-pourrat/kubernetes-ingress-controller that referenced this issue Oct 11, 2023
ludovic-pourrat added a commit to ludovic-pourrat/kubernetes-ingress-controller that referenced this issue Oct 11, 2023
ludovic-pourrat added a commit to ludovic-pourrat/kubernetes-ingress-controller that referenced this issue Oct 11, 2023
ludovic-pourrat added a commit to ludovic-pourrat/kubernetes-ingress-controller that referenced this issue Oct 11, 2023
@ludovic-pourrat
Copy link
Contributor Author

PR merged, many thanks for you prompt and great support !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants