Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix typo in UDPRoute controller's watch #4835

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 12, 2023

What this PR does / why we need it:

Fixes a typo in UDPRoute controller's watch which is set to watch status updates.

Special notes for your reviewer:

This should fail a test or 2, how come this didn't 🤔 ?

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek added the fix label Oct 12, 2023
@pmalek pmalek added this to the KIC v3.0.0 milestone Oct 12, 2023
@pmalek pmalek self-assigned this Oct 12, 2023
@pmalek pmalek force-pushed the fix-typo-in-UDPRoute-controller branch from 299dbd7 to 736d893 Compare October 12, 2023 16:39
@pmalek pmalek marked this pull request as ready for review October 12, 2023 16:39
@pmalek pmalek requested a review from a team as a code owner October 12, 2023 16:39
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (df6452c) 77.9% compared to head (736d893) 77.9%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4835     +/-   ##
=======================================
- Coverage   77.9%   77.9%   -0.1%     
=======================================
  Files        163     163             
  Lines      18537   18537             
=======================================
- Hits       14458   14441     -17     
- Misses      3271    3284     +13     
- Partials     808     812      +4     
Files Coverage Δ
...nternal/controllers/gateway/udproute_controller.go 71.8% <50.0%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randmonkey randmonkey merged commit f711b2a into main Oct 13, 2023
34 checks passed
@randmonkey randmonkey deleted the fix-typo-in-UDPRoute-controller branch October 13, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants