Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix typo in UDPRoute controller's watch #4835

Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix: fix typo in UDPRoute controller's watch #4835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ Adding a new version? You'll need three changes:
will be included in the message reported in `KongConfigurationApplyFailed` Kubernetes event
generated for it.
[#4813](https://github.com/Kong/kubernetes-ingress-controller/pull/4813)
- Fixed an incorrect watch, set in UDPRoute controller watching UDProute status updates.
[#4835](https://github.com/Kong/kubernetes-ingress-controller/pull/4835)

### Changed

Expand Down
4 changes: 2 additions & 2 deletions internal/controllers/gateway/udproute_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func (r *UDPRouteReconciler) SetupWithManager(mgr ctrl.Manager) error {
&source.Channel{Source: r.StatusQueue.Subscribe(schema.GroupVersionKind{
Group: gatewayv1alpha2.GroupVersion.Group,
Version: gatewayv1alpha2.GroupVersion.Version,
Kind: "TCPRoute",
Kind: "UDPRoute",
})},
&handler.EnqueueRequestForObject{},
); err != nil {
Expand Down Expand Up @@ -380,7 +380,7 @@ func (r *UDPRouteReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
}

if configurationStatus == k8sobj.ConfigurationStatusFailed {
debug(log, udproute, "tcproute configuration failed")
debug(log, udproute, "udproute configuration failed")
statusUpdated, err := ensureParentsProgrammedCondition(ctx, r.Status(), udproute, udproute.Status.Parents, gateways, metav1.Condition{
Status: metav1.ConditionFalse,
Reason: string(ConditionReasonTranslationError),
Expand Down