Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove all in one dbless legacy manifest #4866

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 16, 2023

What this PR does / why we need it:

This removes the legacy (already deprecated) dbless, all in one manifest, which deployed Kong Gateway and KIC in the same Pod.

Which issue this PR fixes:

Part of #4671

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek requested a review from a team as a code owner October 16, 2023 20:23
@pmalek pmalek self-assigned this Oct 16, 2023
@pmalek pmalek added this to the KIC v3.0.0 milestone Oct 16, 2023
@pmalek pmalek enabled auto-merge (squash) October 16, 2023 20:41
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0cf6c77) 77.6% compared to head (d2a6968) 75.4%.
Report is 2 commits behind head on main.

❗ Current head d2a6968 differs from pull request most recent head c545c71. Consider uploading reports for the commit c545c71 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4866     +/-   ##
=======================================
- Coverage   77.6%   75.4%   -2.3%     
=======================================
  Files        164     164             
  Lines      18409   18409             
=======================================
- Hits       14301   13896    -405     
- Misses      3288    3703    +415     
+ Partials     820     810     -10     

see 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek merged commit 32bd51a into main Oct 17, 2023
33 checks passed
@pmalek pmalek deleted the remove-all-in-one-legacy branch October 17, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants