Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the sidecar (non-GD) mode in DB-less #4671

Open
1 of 2 tasks
mflendrich opened this issue Sep 18, 2023 · 5 comments
Open
1 of 2 tasks

Deprecate the sidecar (non-GD) mode in DB-less #4671

mflendrich opened this issue Sep 18, 2023 · 5 comments
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. blocked

Comments

@mflendrich
Copy link
Contributor

mflendrich commented Sep 18, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

#702 has added Gateway Discovery that has been offered as a (default on) alternative in the deploy manifests and in the kong/ingress Helm chart.

3.0 is good time to officially discontinue the legacy (sidecar) model.

Proposed Solution

  • Make kong/ingress the only recommended way of installing KIC in the documentation.
  • Let the documentation state that the sidecar model is no longer supported as of 3.0.
  • Explicitly disallow the sidecar model in the Kong/kong Helm chart if KIC >= 3.0.

Additional information

This only refers to DB-less.

Acceptance Criteria

  • When following instructions in docs to install DB-mode, the user ends up with a DB mode installation that has GD enabled (and not the sidecar model)
@mflendrich mflendrich added this to the KIC v3.0.0 milestone Sep 18, 2023
@mflendrich mflendrich added area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. blocked labels Sep 18, 2023
@mflendrich
Copy link
Contributor Author

mflendrich commented Sep 20, 2023

Blocked by #4698

@mflendrich mflendrich changed the title Deprecate the sidecar (non-GD) mode Deprecate the sidecar (non-GD) mode in DB-less Sep 28, 2023
@mflendrich
Copy link
Contributor Author

mflendrich commented Sep 28, 2023

Tracking DB mode GD in #4751

@rainest
Copy link
Contributor

rainest commented Oct 31, 2023

Explicitly disallow the sidecar model in the Kong/kong Helm chart if KIC >= 3.0.

This isn't really possible as such. The sidecar model is the only way kong can deploy both the controller and proxy with a single release. ingress is automating some of the work to create multiple releases.

We can't really set up kong to support both sidecar and separate Deployments without making the settings and templates both harder to understand, so I would strongly recommend against it. Supporting only one mode of operation simplifies usage and development, so unless we have a strong reason to support sidecar mode still, we should instead make kong only support multiple Deployments, and then work on figuring out a migration plan for releases created with ingress so that we're no longer stuck with the limitations inherent to umbrella charts.

There shouldn't be any reason to need to use the sidecar model AFAIK, and keeping it if so wouldn't buy us anything other than consistency with earlier versions for consistency's sake.

@pmalek
Copy link
Member

pmalek commented Nov 2, 2023

Make kong/ingress the only recommended way of installing KIC in the documentation.

README.md already points users to use the ingress chart.

@mflendrich
Copy link
Contributor Author

Blocked by Kong/charts#921

@mflendrich mflendrich removed this from the KIC v3.0.x milestone Nov 8, 2023
@rainest rainest removed their assignment Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. blocked
Projects
None yet
Development

No branches or pull requests

4 participants