feat: KongUpstreamPolicy accepted condition

[mlavacca]

What this PR does / why we need it:

Which issue this PR fixes:

Fixes #4932
Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

• the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

[codecov]

Codecov Report

Attention: 135 lines in your changes are missing coverage. Please review.

Comparison is base (48ad16e) 73.5% compared to head (e972c1e) 75.8%.
Report is 3 commits behind head on main.

Files	Patch %	Lines
...ers/configuration/kongupstreampolicy_controller.go	29.5%	86 Missing and 7 partials ⚠️
...trollers/configuration/kongupstreampolicy_utils.go	71.2%	29 Missing and 13 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #5185     +/-   ##
=======================================
+ Coverage   73.5%   75.8%   +2.3%     
=======================================
  Files        170     172      +2     
  Lines      19584   19825    +241     
=======================================
+ Hits       14398   15039    +641     
+ Misses      4348    3933    -415     
- Partials     838     853     +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[randmonkey]

The implementation seems to assumpted that HTTPRoute is always present in the cluster, but gateway API are not installed by default so there is possibility that HTTPRoute does not exist in the cluster. I am not sure if this will cause unexpected behavior such as controller crash or endless reconcilng loop.

[czeslavo]

Before merging, I think we should cover the reconciler with envtests to verify the status is populated as expected. We could also cover all the added helpers with unit tests (I'd highly encourage to do so).

Another important point is that KongUpstreamPolicy might be attached not only to Services that are used as HTTPRoutes' backends, but also with any other Gateway API Route that we support and netv1.Ingress as well. I suggest we create a separate issue to handle all other Routes and Ingress references similarly to how we handle HTTPRoute in this PR.

[mlavacca]

I created some follow-up issues to this one to avoid having is a gigantic PR

Before merging, I think we should cover the reconciler with envtests to verify the status is populated as expected. We could also cover all the added helpers with unit tests (I'd highly encourage to do so).

Here is an issue about adding integration tests: #5292. In addition to that, I'll add some unit tests for the helpers in this PR. Does it sound good to you?

Another important point is that KongUpstreamPolicy might be attached not only to Services that are used as HTTPRoutes' backends, but also with any other Gateway API Route that we support and netv1.Ingress as well. I suggest we create a separate issue to handle all other Routes and Ingress references similarly to how we handle HTTPRoute in this PR.

And here is the issue about checking the ingress: #5293

[czeslavo]

@mlavacca Yes, that makes sense to me, thanks for creating follow-up issues!

[mlavacca]

The implementation seems to assumpted that HTTPRoute is always present in the cluster, but gateway API are not installed by default so there is possibility that HTTPRoute does not exist in the cluster. I am not sure if this will cause unexpected behavior such as controller crash or endless reconcilng loop.

The controller does not start unless the gateway API is installed in the cluster, as it is wrapped by the dynamicCRDcontroller

kubernetes-ingress-controller/internal/manager/controllerdef.go

Lines 254 to 274 in 4ee9eff

	{
	Enabled: c.KongUpstreamPolicyEnabled,
	Controller: &crds.DynamicCRDController{
	Manager: mgr,
	Log: ctrl.LoggerFrom(ctx).WithName("controllers").WithName("Dynamic/KongUpstreamPolicy"),
	CacheSyncTimeout: c.CacheSyncTimeout,
	RequiredCRDs: []schema.GroupVersionResource{
	{
	Group: gatewayv1.GroupVersion.Group,
	Version: gatewayv1.GroupVersion.Version,
	Resource: "httproutes",
	},
	},
	Controller: &configuration.KongUpstreamPolicyReconciler{
	Client: mgr.GetClient(),
	Log: ctrl.LoggerFrom(ctx).WithName("controllers").WithName("KongUpstreamPolicy"),
	Scheme: mgr.GetScheme(),
	DataplaneClient: dataplaneClient,
	CacheSyncTimeout: c.CacheSyncTimeout,
	},
	},