Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Ingresses incompatibilities when setting KongUpstreamPolicy status #5293

Closed
1 task
Tracked by #5291
mlavacca opened this issue Dec 5, 2023 · 3 comments
Closed
1 task
Tracked by #5291
Assignees
Labels
area/feature New feature or request
Milestone

Comments

@mlavacca
Copy link
Member

mlavacca commented Dec 5, 2023

Problem Statement

#4932 populates the kongUpstreamPolicy status and checks conflicts on HTTPRoutes. Conflicts on Ingress references must be checked as well, and the proper reason must be set in the Ancestor Accepted condition.

Acceptance Criteria

  • All services referenced by an Ingress must be checked. If there is conflict on the policies referenced, the Conflicted Reason must be used in the Accepted condition of the Ancestor status.
@mlavacca
Copy link
Member Author

mlavacca commented Dec 5, 2023

Blocked by #4932

@mlavacca mlavacca changed the title Check Ingresses incompatibilities when setting KongUpstreamPolicy Check Ingresses incompatibilities when setting KongUpstreamPolicy status Dec 6, 2023
@mflendrich
Copy link
Contributor

Removing the blocked label as #4932 is done

@czeslavo
Copy link
Contributor

Because there's no scenario in which we could have a conflict in Ingress (there's no concept of multiple backend references in a single Ingress rule), this can be closed as not needed.

@czeslavo czeslavo closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants