Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support of KongServiceFacade as default Ingress backend #5282

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Dec 4, 2023

What this PR does / why we need it:

Adds support for KongServiceFacade as a default Ingress backend along with tests.

Which issue this PR fixes:

Part of #5152.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo self-assigned this Dec 4, 2023
@czeslavo czeslavo added area/feature New feature or request and removed size/L labels Dec 4, 2023
@czeslavo czeslavo added this to the KIC v3.1.x milestone Dec 4, 2023
@czeslavo czeslavo force-pushed the feat/default-ingress-backend-facade branch from a1cc3ce to 28126c7 Compare December 4, 2023 17:25
@czeslavo czeslavo changed the title feat: add support of KongServiceFacade support as default Ingress backend feat: add support of KongServiceFacade as default Ingress backend Dec 4, 2023
@czeslavo czeslavo force-pushed the feat/default-ingress-backend-facade branch from 28126c7 to dc100c7 Compare December 4, 2023 17:26
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (64a0a61) 75.5% compared to head (9cb0561) 75.6%.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/util/builder/ingress.go 0.0% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5282   +/-   ##
=====================================
  Coverage   75.5%   75.6%           
=====================================
  Files        170     170           
  Lines      19385   19457   +72     
=====================================
+ Hits       14644   14710   +66     
- Misses      3910    3914    +4     
- Partials     831     833    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo force-pushed the feat/default-ingress-backend-facade branch 3 times, most recently from fc46155 to 5494838 Compare December 4, 2023 20:19
@czeslavo czeslavo marked this pull request as ready for review December 4, 2023 20:28
@czeslavo czeslavo requested a review from a team as a code owner December 4, 2023 20:28
@czeslavo czeslavo force-pushed the feat/default-ingress-backend-facade branch from 5494838 to b1149b3 Compare December 5, 2023 11:14
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Dec 5, 2023
@czeslavo czeslavo force-pushed the feat/default-ingress-backend-facade branch from b1149b3 to fb58d5c Compare December 5, 2023 11:16
@czeslavo czeslavo force-pushed the feat/default-ingress-backend-facade branch from fb58d5c to 9cb0561 Compare December 5, 2023 11:21
@czeslavo czeslavo merged commit 9bbee3b into main Dec 5, 2023
37 checks passed
@czeslavo czeslavo deleted the feat/default-ingress-backend-facade branch December 5, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants