-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support of KongServiceFacade as default Ingress backend #5282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
feat/default-ingress-backend-facade
branch
from
December 4, 2023 17:25
a1cc3ce
to
28126c7
Compare
czeslavo
changed the title
feat: add support of KongServiceFacade support as default Ingress backend
feat: add support of KongServiceFacade as default Ingress backend
Dec 4, 2023
czeslavo
force-pushed
the
feat/default-ingress-backend-facade
branch
from
December 4, 2023 17:26
28126c7
to
dc100c7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5282 +/- ##
=====================================
Coverage 75.5% 75.6%
=====================================
Files 170 170
Lines 19385 19457 +72
=====================================
+ Hits 14644 14710 +66
- Misses 3910 3914 +4
- Partials 831 833 +2 ☔ View full report in Codecov by Sentry. |
czeslavo
force-pushed
the
feat/default-ingress-backend-facade
branch
3 times, most recently
from
December 4, 2023 20:19
fc46155
to
5494838
Compare
randmonkey
reviewed
Dec 5, 2023
randmonkey
reviewed
Dec 5, 2023
czeslavo
force-pushed
the
feat/default-ingress-backend-facade
branch
from
December 5, 2023 11:14
5494838
to
b1149b3
Compare
czeslavo
force-pushed
the
feat/default-ingress-backend-facade
branch
from
December 5, 2023 11:16
b1149b3
to
fb58d5c
Compare
czeslavo
force-pushed
the
feat/default-ingress-backend-facade
branch
from
December 5, 2023 11:21
fb58d5c
to
9cb0561
Compare
randmonkey
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for
KongServiceFacade
as a default Ingress backend along with tests.Which issue this PR fixes:
Part of #5152.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR