fix: properly detect UpstreamPolicy conflict in HTTPRoutes #5417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This ensures that the
Accepted
condition inKongUpstreamPolicy
ancestor's status is set toConflicted
for aService
used in anHTTPRoute
only if it is used together with a differentService
in a single HTTPRoute's rule.Before this change, we'd set
Conflicted
even ifService
s using differentKongUpstreamPolicies
were used in separate rules in an HTTPRoute, which shouldn't be the case.Which issue this PR fixes:
It fixes a problem discovered during work on #5293.
Special notes for your reviewer:
Changelog entry was omitted as it is a fix to a net new feature that hasn't been released yet.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:- [ ] theCHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR