Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Programmed condition to KongUpstreamPolicy ancestors status #5444

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Jan 15, 2024

What this PR does / why we need it:

Adds Programmed condition to KongUpstreamPolicy ancestors status for Service and KongServiceFacade based on their configuration status in the data plane.

Which issue this PR fixes:

Closes #5249.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo self-assigned this Jan 15, 2024
@czeslavo czeslavo added this to the KIC v3.1.x milestone Jan 15, 2024
@czeslavo czeslavo force-pushed the feat/programmed-upstream-policy branch 2 times, most recently from abad5bb to f2fad06 Compare January 15, 2024 19:55
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (c0e5828) 69.8% compared to head (1c51035) 71.5%.

Files Patch % Lines
...ers/configuration/kongupstreampolicy_controller.go 56.9% 23 Missing and 8 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5444     +/-   ##
=======================================
+ Coverage   69.8%   71.5%   +1.7%     
=======================================
  Files        176     176             
  Lines      22626   22723     +97     
=======================================
+ Hits       15795   16255    +460     
+ Misses      5904    5513    -391     
- Partials     927     955     +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feat/support-service-facade-ancestor to main January 16, 2024 10:24
@czeslavo czeslavo force-pushed the feat/programmed-upstream-policy branch from f2fad06 to 13d8087 Compare January 16, 2024 10:55
@czeslavo czeslavo force-pushed the feat/programmed-upstream-policy branch from 13d8087 to 96cbf05 Compare January 16, 2024 10:57
@czeslavo czeslavo marked this pull request as ready for review January 16, 2024 10:58
@czeslavo czeslavo requested a review from a team as a code owner January 16, 2024 10:58
@czeslavo czeslavo force-pushed the feat/programmed-upstream-policy branch 4 times, most recently from 756d405 to 08c372b Compare January 18, 2024 09:25
@czeslavo czeslavo marked this pull request as draft January 18, 2024 10:28
@czeslavo czeslavo force-pushed the feat/programmed-upstream-policy branch from 08c372b to 1c51035 Compare January 18, 2024 13:32
@czeslavo czeslavo marked this pull request as ready for review January 18, 2024 13:33
@tao12345666333 tao12345666333 merged commit cfcf7b2 into main Jan 19, 2024
38 checks passed
@tao12345666333 tao12345666333 deleted the feat/programmed-upstream-policy branch January 19, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set the Programmed condition in the KongUpstreamPolicy ancestor status
3 participants