Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow multiple subscribers on single GVK status updates #5452

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

czeslavo
Copy link
Contributor

What this PR does / why we need it:

So far, we haven't had a case where we'd need two separate subscribers to receive channel status update notifications for a single GVK. #5444 introduces a Watch in KongUpstreamPolicy controller that needs to receive status updates of KongServiceFacade which already has one subscriber in its controller. This PR mitigates issues that might occur because of multiple subscribers consuming notifications from a single channel by creating a separate channel for every Subscribe call.

Which issue this PR fixes:

Follow up of #5444.

@czeslavo czeslavo self-assigned this Jan 18, 2024
@czeslavo czeslavo added this to the KIC v3.1.x milestone Jan 18, 2024
@czeslavo czeslavo marked this pull request as ready for review January 18, 2024 10:28
@czeslavo czeslavo requested a review from a team as a code owner January 18, 2024 10:28
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7175352) 69.8% compared to head (bc310a4) 69.8%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5452     +/-   ##
=======================================
- Coverage   69.8%   69.8%   -0.1%     
=======================================
  Files        176     176             
  Lines      22633   22626      -7     
=======================================
- Hits       15804   15793     -11     
- Misses      5901    5906      +5     
+ Partials     928     927      -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pmalek
pmalek previously approved these changes Jan 18, 2024
internal/util/kubernetes/object/status/queue.go Outdated Show resolved Hide resolved
@czeslavo czeslavo enabled auto-merge (squash) January 18, 2024 12:48
@czeslavo czeslavo merged commit c0e5828 into main Jan 18, 2024
37 checks passed
@czeslavo czeslavo deleted the feat/multiple-sub-status-queue branch January 18, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants