Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway-api): support ReplaceFullPath for URLRewrite #5855

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Apr 10, 2024

What this PR does / why we need it:

This PR introduces support for FullPathRewrite for URLRewrite filter for HTTPRoutes.

Separate PRs will introduce remaining features of URLRewrite.

Which issue this PR fixes:

Part of #3686.

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek added the area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API label Apr 10, 2024
@pmalek pmalek self-assigned this Apr 10, 2024
@pmalek pmalek force-pushed the gwapi-urlrewrite-replacefullpath branch 2 times, most recently from 5d4e4af to caff522 Compare April 11, 2024 09:49
@pmalek pmalek marked this pull request as ready for review April 11, 2024 09:49
@pmalek pmalek requested a review from a team as a code owner April 11, 2024 09:49
@pmalek pmalek added this to the KIC v3.2.x milestone Apr 11, 2024
@pmalek pmalek force-pushed the gwapi-urlrewrite-replacefullpath branch from 407761a to 3ebe954 Compare April 11, 2024 12:08
@pmalek pmalek requested a review from czeslavo April 11, 2024 12:09
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 71.05263% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 72.1%. Comparing base (ea1864c) to head (3ebe954).
Report is 2 commits behind head on main.

Files Patch % Lines
...al/dataplane/translator/subtranslator/httproute.go 62.0% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5855   +/-   ##
=====================================
  Coverage   72.0%   72.1%           
=====================================
  Files        178     178           
  Lines      18210   18246   +36     
=====================================
+ Hits       13127   13159   +32     
- Misses      4107    4110    +3     
- Partials     976     977    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek merged commit b9bf11d into main Apr 11, 2024
38 checks passed
@pmalek pmalek deleted the gwapi-urlrewrite-replacefullpath branch April 11, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants