Add host_header annotation for Services #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a "konghq.com/host-header" annotation for Services. The annotation sets the "host_header" parameter on the upstream associated with the Service, similar to the equivalent KongIngress setting added in bc506ef. Split overrideUpstream logic into separate overrideUpstreamByAnnotation and overrideUpstreamByKongIngress functions called by overrideUpstream.
hbagdi
reviewed
Apr 13, 2020
added 2 commits
April 13, 2020 14:37
* Move name copy inside overrideUpstreamByKongIngress * Copy entire KongIngress upstream at once rather than piecemeal * Correct erroneous comment
hbagdi
approved these changes
Apr 14, 2020
| @@ -179,7 +180,12 @@ func HasServiceUpstreamAnnotation(anns map[string]string) bool { | |||
| return anns["ingress.kubernetes.io/service-upstream"] == "true" | |||
| } | |||
|
|
|||
| // ExtractRegexPriority extracts the regex-priority annotation value. | |||
| // ExtractRegexPriority extracts the host-header annotation value. | |||
There was a problem hiding this comment.
You flipped the godoc in the two methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a
konghq.com/host-headerannotation for Services. The annotation sets thehost_headerparameter on the upstream associated with the Service, similar to the equivalent KongIngress setting added in bc506ef.Special notes for your reviewer:
I forgot documentation for
regex-priorityand held off adding it for this one. Currently next does not have the fixes from 36474a5, and adding new docs would probably create conflicts. Do you have a standard process for rebasing next off master, or does it make more sense to just cherry-pick it?