-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(custom_entity): add KCE controller #6055
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6055 +/- ##
=======================================
- Coverage 74.6% 74.3% -0.3%
=======================================
Files 194 198 +4
Lines 18861 19743 +882
=======================================
+ Hits 14072 14677 +605
- Misses 3814 4061 +247
- Partials 975 1005 +30 ☔ View full report in Codecov by Sentry. |
3a1f792
to
663d12d
Compare
9dc3bfa
to
e1acce3
Compare
e1acce3
to
d91cdc0
Compare
d91cdc0
to
76e0289
Compare
76e0289
to
585a105
Compare
a88cba2
to
ee51372
Compare
00a8f9b
to
661c6ab
Compare
661c6ab
to
7f17bca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typos and we're close to merging this.
Just for clarification about fakes vs mocks vs stubs which I believe is already incorrectly used across the codebase:
We're referring to fakes in our codebase to entities that are service a purpose that is reserved for stubs.
Fakes are meant to be implementations that perform some sort of a shortcut (e.g. use memory backed storage instead of DB). Stubs are meant to
provide canned answers to calls made during the test, usually not responding at all to anything outside of what’s programmed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing which I believe is important: can we add at least 1 example manifest to https://github.com/Kong/kubernetes-ingress-controller/tree/9dfe2123b277e8ba418152ff1536c9e696786a7f/examples that will use the custom entity CRD?
I would include this in PR for integration tests. |
What this PR does / why we need it:
The initial (and largest) part of
KongCustomEntity
controller.Which issue this PR fixes:
Major part of #5976
Special notes for your reviewer:
It invokes a procedure to get referred entities of plugins to fill IDs of the entities to the "foreign" fields of custom entities. It is finished in
getServiceIDFromPluginRels
method. I think we can change thegetPluginRels
method to store pointers to the entities instead of identifiers, because with the entities itself we can do more operations on it.PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR