Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate and push fallback config on update failure #6071

Merged
merged 2 commits into from
May 23, 2024

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented May 22, 2024

What this PR does / why we need it:

Makes KongClient try to recover from regular config update failures by generating a fallback configuration, excluding affected objects reported back by gateways.

Enables integration tests with the FallbackConfiguration feature gate enabled to ensure no existing scenarios are broken.

Adds only unit tests covering KongClient. More integration/E2E test coverage is expected to be added under #5933.

Which issue this PR fixes:

Closes #5931.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo self-assigned this May 22, 2024
@czeslavo czeslavo added area/feature New feature or request and removed size/XL labels May 22, 2024
@czeslavo czeslavo added this to the KIC v3.2.x milestone May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 71.2%. Comparing base (763d7d1) to head (f877388).
Report is 5 commits behind head on main.

Current head f877388 differs from pull request most recent head f62fef2

Please upload reports for the commit f62fef2 to get more accurate results.

Files Patch % Lines
internal/dataplane/kong_client.go 84.8% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6071     +/-   ##
=======================================
- Coverage   74.6%   71.2%   -3.4%     
=======================================
  Files        194     195      +1     
  Lines      18861   18956     +95     
=======================================
- Hits       14072   13513    -559     
- Misses      3814    4476    +662     
+ Partials     975     967      -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo force-pushed the feat/push-fallback-config branch 4 times, most recently from a1e1085 to cf47578 Compare May 23, 2024 07:48
@czeslavo czeslavo marked this pull request as ready for review May 23, 2024 08:16
@czeslavo czeslavo requested a review from a team as a code owner May 23, 2024 08:16
internal/dataplane/kong_client.go Show resolved Hide resolved
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
@czeslavo czeslavo enabled auto-merge (squash) May 23, 2024 16:35
@czeslavo czeslavo merged commit 9b86378 into main May 23, 2024
37 checks passed
@czeslavo czeslavo deleted the feat/push-fallback-config branch May 23, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate building and pushing fallback configuration into KongClient.Update
2 participants