-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate and push fallback config on update failure #6071
Conversation
f58c7f4
to
f877388
Compare
f877388
to
f62fef2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6071 +/- ##
=======================================
- Coverage 74.6% 71.2% -3.4%
=======================================
Files 194 195 +1
Lines 18861 18956 +95
=======================================
- Hits 14072 13513 -559
- Misses 3814 4476 +662
+ Partials 975 967 -8 ☔ View full report in Codecov by Sentry. |
a1e1085
to
cf47578
Compare
cf47578
to
3803246
Compare
What this PR does / why we need it:
Makes
KongClient
try to recover from regular config update failures by generating a fallback configuration, excluding affected objects reported back by gateways.Enables integration tests with the
FallbackConfiguration
feature gate enabled to ensure no existing scenarios are broken.Adds only unit tests covering
KongClient
. More integration/E2E test coverage is expected to be added under #5933.Which issue this PR fixes:
Closes #5931.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR