Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix several issues noted here: https://github.com/Kong/kong/issues/3024 #15

Merged
merged 1 commit into from
Jan 10, 2018
Merged

fix several issues noted here: https://github.com/Kong/kong/issues/3024 #15

merged 1 commit into from
Jan 10, 2018

Conversation

bungle
Copy link
Member

@bungle bungle commented Jan 10, 2018

Summary

  • fix :deleteto work with ipairs
  • fix to not start processing header while processing value
  • change style
  • remove Penlight dependency from .rockspec
  • mark release 0.5.3

@bungle bungle mentioned this pull request Jan 10, 2018
Closed
hishamhm
hishamhm reviewed Jan 10, 2018
View reviewed changes
src/multipart.lua Outdated
else
if is_header(line) then
if not processing_part_value and is_header(line) then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not processing_part_value is true, then there's not need to set it to false on the following line

@bungle bungle mentioned this pull request Jan 10, 2018
Merged
@bungle bungle merged commit f73fb9f into master Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishamhm hishamhm hishamhm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bungle @hishamhm