feat: add awsv4 presign and rds util #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windmgc
changed the title
|
@Tieske Could you please review this? Thanks! I will continue adding more test cases for presign during the review process |
Tieske
requested changes
Feb 15, 2023
Comment on lines
5
to
7
| ngx.time = function() | ||
| return 1667543171 | ||
| end |
There was a problem hiding this comment.
This changes the global environment, and hence will spill over to other tests.
This should probably be in a setup block, with a matching teardown block to undo the change
There was a problem hiding this comment.
fixed in before_each and after_each
fixed in setup and teardown
|
@windmgc I added a commit to update the doc comments to render properly. please check; |
|
@Tieske thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two features:
Performing aws_v4 presign on request
The aws_v4 presigning flow has a few differences from the aws_v4 signing flow, this PR is imitating the presigning flow in AWS Go SDK(I'm not very much familiar with JS syntax but the AWS JS SDK would do a similar thing I guess).
Providing RDS utils to build IAM auth token
This is a pre-step of implementing the IAM Database authentication feature in the Kong Gateway(KAG-167. For more details about generating IAM RDS Authentication token, please check https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.IAMDBAuth.Connecting.Go.html
and https://github.com/aws/aws-sdk-go/blob/c7ddff5bbc5ce2facdb433d814b05b3a46d7da05/service/rds/rdsutils/connect.go#L36
Please note that the PR is still working in progress.TODO: