replace intreface with more SDK like interface #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
windmgc
reviewed
Feb 28, 2023
| end | ||
|
|
||
| -- service specifics | ||
| -- see https://github.com/aws/aws-sdk-js/blob/9295e45fdcda93b62f8c1819e924cdb4fb378199/lib/rds/signer.js#L11-L15 |
There was a problem hiding this comment.
Interesting...so the JS SDK consider this as part of the RDS "service class"
|
@Tieske I fixed the param(from self to self.config) that passed to presign function and fixed test accordingly. After the fix I tested locally with my RDS and it worked as expected, thanks for the interface refactor! |
…ance name and database name
Tieske
commented
Mar 1, 2023
| @@ -99,7 +99,7 @@ local function getAuthToken(self, opts) --endpoint, region, db_user) | |||
| }, | |||
| } | |||
|
|
|||
| local presigned_request, err = presign_awsv4_request(self, req_data, opts.signingName, region, RDS_IAM_AUTH_EXPIRE_TIME) | |||
| local presigned_request, err = presign_awsv4_request(self.config, req_data, opts.signingName, region, RDS_IAM_AUTH_EXPIRE_TIME) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the docs and reviewing the official SDK implementation, I changed the interface to be more like the AWS SDK for JS.
Please have a look. The example code explains how to use it after the changes.
WARNING: I didn't have an RDS database to test against, so please verify it still works
(I did verify the local config changes to work)