fix(broker): worker id based queues #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luacheck Report4 tests +3 0 ✅ ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 2e9f34d. ± Comparison against base commit b8606c5. ♻️ This comment has been updated with latest results. |
bungle
force-pushed
the
feat/worker-id-based-queues-only
branch
2 times, most recently
from
32ffd13
to
c0c7116
Compare
gszr
force-pushed
the
feat/worker-id-based-queues-only
branch
from
c0c7116
to
b8f3caa
Compare
gszr
reviewed
Jun 18, 2024
bungle
force-pushed
the
feat/worker-id-based-queues-only
branch
3 times, most recently
from
dfefb27
to
c040876
Compare
tzssangglass
previously approved these changes
Jun 19, 2024
bungle
force-pushed
the
feat/worker-id-based-queues-only
branch
from
c040876
to
c26675d
Compare
bungle
force-pushed
the
feat/worker-id-based-queues-only
branch
4 times, most recently
from
ab857cd
to
6489e60
Compare
### Summary Switches from worker connection based broker queues to worker id based broker queues that makes it possible to retain events even when worker has not yet connected (on node startup), or worker is restarting/reloading.
bungle
force-pushed
the
feat/worker-id-based-queues-only
branch
from
6489e60
to
2e9f34d
Compare
gszr
approved these changes
Jun 19, 2024
hanshuebner
approved these changes
Jun 19, 2024
bungle
added a commit
that referenced
this pull request
Jun 19, 2024
### Summary - [style(lib/compat): update module version](#57) - [tests(*): use resty.events.new correctly as documented](#59) - [feat(protocol): send worker info (id and pid) to broker](#54) - [fix(*): option validation of broker id](#62) - [fix(broker): worker id based queues](#60) - [chore(worker): actively close connection to broker on error](#63) - [fix(*): retain events on send failures](#61)
Merged
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 19, 2024
### Summary - [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
that referenced
this pull request
Jun 19, 2024
### Summary - [style(lib/compat): update module version](#57) - [tests(*): use resty.events.new correctly as documented](#59) - [feat(protocol): send worker info (id and pid) to broker](#54) - [fix(*): option validation of broker id](#62) - [fix(broker): worker id based queues](#60) - [chore(worker): actively close connection to broker on error](#63) - [fix(*): retain events on send failures](#61)
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 19, 2024
### Summary - [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 19, 2024
### Summary - [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 19, 2024
### Summary - [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 20, 2024
- [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 20, 2024
- [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 20, 2024
- [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 20, 2024
- [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 21, 2024
- [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 21, 2024
- [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 28, 2024
- [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 28, 2024
- [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Switches from worker connection based broker queues to worker id based broker queues that makes it possible to retain events even when worker has not yet connected (on node startup), or worker is restarting/reloading.