fix(*): option validation of broker id #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary The option name is `broker_id` but code says that `worker_id` is invalid. This commit fixes that.
Luacheck Report1 tests ±0 0 ✅ ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit c4a7a2f. ± Comparison against base commit 459f8db. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
tzssangglass
approved these changes
Jun 19, 2024
windmgc
approved these changes
Jun 19, 2024
bungle
added a commit
that referenced
this pull request
Jun 19, 2024
### Summary - [style(lib/compat): update module version](#57) - [tests(*): use resty.events.new correctly as documented](#59) - [feat(protocol): send worker info (id and pid) to broker](#54) - [fix(*): option validation of broker id](#62) - [fix(broker): worker id based queues](#60) - [chore(worker): actively close connection to broker on error](#63) - [fix(*): retain events on send failures](#61)
Merged
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 19, 2024
### Summary - [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
that referenced
this pull request
Jun 19, 2024
### Summary - [style(lib/compat): update module version](#57) - [tests(*): use resty.events.new correctly as documented](#59) - [feat(protocol): send worker info (id and pid) to broker](#54) - [fix(*): option validation of broker id](#62) - [fix(broker): worker id based queues](#60) - [chore(worker): actively close connection to broker on error](#63) - [fix(*): retain events on send failures](#61)
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 19, 2024
### Summary - [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 19, 2024
### Summary - [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 19, 2024
### Summary - [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 20, 2024
- [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 20, 2024
- [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 20, 2024
- [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 20, 2024
- [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 21, 2024
- [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 21, 2024
- [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 28, 2024
- [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
added a commit
to Kong/kong
that referenced
this pull request
Jun 28, 2024
- [style(lib/compat): update module version](Kong/lua-resty-events#57) - [tests(*): use resty.events.new correctly as documented](Kong/lua-resty-events#59) - [feat(protocol): send worker info (id and pid) to broker](Kong/lua-resty-events#54) - [fix(*): option validation of broker id](Kong/lua-resty-events#62) - [fix(broker): worker id based queues](Kong/lua-resty-events#60) - [chore(worker): actively close connection to broker on error](Kong/lua-resty-events#63) - [fix(*): retain events on send failures](Kong/lua-resty-events#61) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The option name is
broker_idbut code says thatworker_idis invalid. This commit fixes that.