feat: fix types aligning with doc; and support null for mutate #274
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
4 tasks
darrenjennings
requested changes
Mar 12, 2022
| config?: IConfig | ||
| ): IResponse<Data, Error> | ||
| function useSWRV<Data = any, Error = any> (...args): IResponse<Data, Error> { | ||
| let key: IKey | ||
| let fn: fetcherFn<Data> | undefined | ||
| let fn: fetcherFn<Data> | undefined | null |
There was a problem hiding this comment.
looks like this is already fixed, can you 1. resolve conflicts, and 2. write a test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc says
But type doesn't accept
nullas fetcher. resolves #148In addition,
mutate(internallyrevalidate) does not treatnullas special value differing toundefined. This changes runtime behavior a little. Now we can overridemutatefetcher function withnulleven if initial fetcher function is notnull.undefinedstays as falling back to initial fetcher.