Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Location sort to GoPro, Android and DJI #50

Merged
merged 17 commits into from Dec 25, 2022
Merged

Add Location sort to GoPro, Android and DJI #50

merged 17 commits into from Dec 25, 2022

Conversation

KonradIT
Copy link
Owner

@KonradIT KonradIT commented Dec 23, 2022

Add Location sort to GoPro, Android and DJI

Closes #14

Adds sort by location when importing to GoPro and DJI. Insta360 is not supported yet because I don't have any video with GPS on it.

Todo:

  • Add some config params:
    • Order when importing: if both camera and location fields are selected, then the output path will be: date + location + device. Config key needs to allow for changing order.
    • Change location string format, right now it follows this logic: if len(address.City) < 9 && address.State != "" return city + state + country else return city + country. Support other formats, maybe by street/postal code etc...
    • Boolean flag for having NoLocation fallback folder (eg: DJI Drone timelapses, non-GPS GoPro media goes here)
  • Support GoPro Connect (investigate get GPMF via API)
  • Add sort by flag support to DJI
  • Do Android photos/videos (use exiftool)
  • Investigate other subtitle formats from DJI, I think Avata's SRT sub is different. Collection of formats
  • DJI: Fix deviceName being the default one when changing order

Type:

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Camera:

  • GoPro
  • Insta360
  • DJI
  • Android
  • This PR adds a new camera

Component:

  • Core logic
  • Import
  • Merging
  • Firmware Update
  • Video Manipulation

Checklist before approval:

  • Linter pass
  • Build pass

@KonradIT KonradIT changed the title Add Location sort to GoPro and DJI Add Location sort to GoPro, Android and DJI Dec 24, 2022
@KonradIT KonradIT added enhancement New feature or request cam-gopro tasks/issues related to gopro cam-dji tasks/issues related to dji labels Dec 24, 2022
@KonradIT KonradIT added this to the v1.5 milestone Dec 25, 2022
@KonradIT KonradIT merged commit dd7f7e7 into development Dec 25, 2022
@KonradIT KonradIT deleted the location branch December 25, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cam-dji tasks/issues related to dji cam-gopro tasks/issues related to gopro enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort by geographic location
1 participant