Merge pull request #74 from KonstantinTomashevich/73-render-foundatio…

…n-improvement

Celerity::RenderFoundation: Frame buffers and render to textures.

Coverage.json

@@ -18,6 +18,11 @@
       "MinimumLinesCoveragePerFilePercent": 65.0,
       "Reason": "It's impossible to fully cover `DoWithCorrectComparator` because of asserts and breaks that will be reached only if something really bad happens."
     },
+    {
+      "Prefix": "./Library/Public/Celerity/Extension/Asset/Celerity/Asset/ManualAssetConstructor.cpp",
+      "Action": "Exclude",
+      "Reason": "Manual asset constructor logic is covered only by GPU dependant tests, therefore there is no coverage on CI."
+    },
     {
       "Prefix": "./Library/Public/Celerity/Extension/Input/Celerity/Input/FrameInputAccumulator.cpp",
       "Action": "CustomMinimumCoverage",

Executable/Platformer2dDemo/Game/Modules/Platformer.cpp

@@ -8,6 +8,7 @@
 #include <Celerity/Physics2d/Simulation.hpp>
 #include <Celerity/PipelineBuilder.hpp>
 #include <Celerity/Render/2d/Rendering2d.hpp>
+#include <Celerity/Render/Foundation/PostProcess.hpp>
 #include <Celerity/Render/Foundation/RenderPipelineFoundation.hpp>
 #include <Celerity/Transform/TransformHierarchyCleanup.hpp>
 #include <Celerity/Transform/TransformVisualSync.hpp>
@@ -95,6 +96,7 @@ void Initializer (GameState &_gameState,
     Emergence::Celerity::Assembly::AddToNormalUpdate (mainPipelineBuilder, GetAssemblerCustomKeys (),
                                                       GetNormalAssemblerTypes (), MAX_ASSEMBLY_TIME_NS);
     Emergence::Celerity::Input::AddToNormalUpdate (mainPipelineBuilder, _gameState.GetFrameInputAccumulator ());
+    Emergence::Celerity::PostProcess::AddToNormalUpdate (mainPipelineBuilder);
     Emergence::Celerity::RenderPipelineFoundation::AddToNormalUpdate (mainPipelineBuilder);
     Emergence::Celerity::Rendering2d::AddToNormalUpdate (mainPipelineBuilder, worldBox);
     Emergence::Celerity::TransformHierarchyCleanup::Add2dToNormalUpdate (mainPipelineBuilder);

Executable/Platformer2dDemo/Game/Modules/Root.cpp

@@ -2,6 +2,7 @@
 #include <Celerity/Asset/AssetManagement.hpp>
 #include <Celerity/Asset/Events.hpp>
 #include <Celerity/Asset/Render/2d/Sprite2dUvAnimationManagement.hpp>
+#include <Celerity/Asset/Render/Foundation/FrameBufferManagement.hpp>
 #include <Celerity/Asset/Render/Foundation/MaterialInstanceManagement.hpp>
 #include <Celerity/Asset/Render/Foundation/MaterialManagement.hpp>
 #include <Celerity/Asset/Render/Foundation/TextureManagement.hpp>
@@ -84,6 +85,7 @@ void Initializer (GameState &_gameState,
                                                              assetReferenceBindingEventMap);
     Emergence::Celerity::FontManagement::AddToNormalUpdate (pipelineBuilder, _gameState.GetResourceProvider (),
                                                             assetReferenceBindingEventMap);
+    Emergence::Celerity::FrameBufferManagement::AddToNormalUpdate (pipelineBuilder);
     Emergence::Celerity::Localization::AddToNormalUpdate (pipelineBuilder, _gameState.GetResourceProvider ());
     Emergence::Celerity::MaterialInstanceManagement::AddToNormalUpdate (
         pipelineBuilder, _gameState.GetResourceProvider (), assetReferenceBindingEventMap);

Library/Private/Celerity/Extension/ImGUI/Public/Celerity/Asset/UI/FontUtility.cpp

@@ -12,12 +12,16 @@ Render::Backend::Texture BakeFontAtlas (ImFontAtlas *_atlas)
     _atlas->GetTexDataAsRGBA32 (&textureData, &textureWidth, &textureHeight);
     EMERGENCE_ASSERT (textureData);
 
-    Render::Backend::Texture texture (textureData, textureWidth, textureHeight, {});
+    Render::Backend::Texture texture = Render::Backend::Texture::CreateFromRaw (
+        textureWidth, textureHeight, Render::Backend::TextureFormat::RGBA8, textureData, {});
+
     const Render::Backend::TextureId atlasTextureId = texture.GetId ();
     static_assert (sizeof (Render::Backend::TextureId) == sizeof (ImTextureID));
+
     BEGIN_MUTING_STRING_ALIASING_WARNINGS
     _atlas->SetTexID (*reinterpret_cast<const ImTextureID *> (&atlasTextureId));
     END_MUTING_WARNINGS
+
     return texture;
 }
 } // namespace Emergence::Celerity

Library/Private/Celerity/Extension/ImGUI/Public/Celerity/UI/UIRendering.cpp

@@ -252,8 +252,7 @@ void UIRenderer::ProcessRenderPass (const UIRenderPass *_renderPass,
 
         if (availableVertices != totalVertices || availableIndices != totalIndices)
         {
-            EMERGENCE_LOG (WARNING,
-                           "Celerity::UI: Unable to submit all draw calls due to being unable to allocate buffers.");
+            EMERGENCE_LOG (WARNING, "UI: Unable to submit all draw calls due to being unable to allocate buffers.");
             break;
         }
 

Library/Private/Galleon/Galleon/CargoDeck.cpp

@@ -27,6 +27,7 @@ CargoDeck::CargoDeck (Memory::UniqueString _name) noexcept
 {
 }
 
+// NOLINTNEXTLINE(modernize-use-equals-default): It's not actually default unless assertions are disabled.
 CargoDeck::~CargoDeck () noexcept
 {
     // Assert that all containers are either detached or exist only due to garbage collection disabled flag.

Library/Private/Pegasus/Private/Pegasus/RecordUtility.hpp

@@ -139,18 +139,14 @@ auto DoWithCorrectComparator (const StandardLayout::Field &_field, const Callbac
         return _callback (UniqueStringValueComparator {});
     }
 
+    // _field should be leaf-field, not intermediate nested object.
     case StandardLayout::FieldArchetype::NESTED_OBJECT:
-    {
-        // _field should be leaf-field, not intermediate nested object.
-        EMERGENCE_ASSERT (false);
-        break;
-    }
 
+    // Vectors, patches and external strings aren't supported for indexing.
     case StandardLayout::FieldArchetype::UTF8_STRING:
     case StandardLayout::FieldArchetype::VECTOR:
     case StandardLayout::FieldArchetype::PATCH:
     {
-        // Vectors, patches and external strings aren't supported for indexing.
         EMERGENCE_ASSERT (false);
         break;
     }

Library/Private/Pegasus/Public/Pegasus/VolumetricIndex.hpp

@@ -593,6 +593,7 @@ void PartitioningTree<Dimensions>::DeleteNodeWithChildren (Node *_node)
 }
 
 template <std::size_t Dimensions>
+// NOLINTNEXTLINE(modernize-use-equals-default): It's actually not default when asserts are enabled.
 PartitioningTree<Dimensions>::Node::~Node () noexcept
 {
 #if defined(EMERGENCE_ASSERT_ENABLED)

Library/Public/Celerity/Extension/Asset/Celerity/Asset/ManualAssetConstructor.cpp

@@ -0,0 +1,28 @@
+#include <Celerity/Asset/Asset.hpp>
+#include <Celerity/Asset/AssetManagerSingleton.hpp>
+#include <Celerity/Asset/ManualAssetConstructor.hpp>
+#include <Celerity/PipelineBuilderMacros.hpp>
+
+namespace Emergence::Celerity
+{
+ManualAssetConstructor::ManualAssetConstructor (TaskConstructor &_constructor) noexcept
+    : modifyAssetManager (MODIFY_SINGLETON (AssetManagerSingleton)),
+      insertAsset (INSERT_LONG_TERM (Asset))
+{
+}
+
+void ManualAssetConstructor::ConstructManualAsset (Memory::UniqueString _assetId,
+                                                   const StandardLayout::Mapping &_assetType) noexcept
+{
+    auto managerCursor = modifyAssetManager.Execute ();
+    auto *manager = static_cast<AssetManagerSingleton *> (*managerCursor);
+    ++manager->unusedAssetCount;
+
+    auto assetCursor = insertAsset.Execute ();
+    auto *asset = static_cast<Asset *> (++assetCursor);
+    asset->id = _assetId;
+    asset->type = _assetType;
+    asset->state = AssetState::READY;
+    asset->usages = 0u;
+}
+} // namespace Emergence::Celerity

Library/Public/Celerity/Extension/Asset/Celerity/Asset/ManualAssetConstructor.hpp

@@ -0,0 +1,31 @@
+#pragma once
+
+#include <Celerity/PipelineBuilder.hpp>
+
+namespace Emergence::Celerity
+{
+/// \brief Utility class for systems that need to manually construct
+///        assets instead of constructing them through references.
+class ManualAssetConstructor final
+{
+public:
+    /// \brief Initializes internal queries using given task constructor,
+    ManualAssetConstructor (TaskConstructor &_constructor) noexcept;
+
+    ManualAssetConstructor (const ManualAssetConstructor &_other) = delete;
+
+    ManualAssetConstructor (ManualAssetConstructor &&_other) = delete;
+
+    ~ManualAssetConstructor () noexcept = default;
+
+    /// \brief Constructs ready to use asset with given id, given type and zero references.
+    /// \warning Asset might be cleaned up later by asset management system unless something references it.
+    void ConstructManualAsset (Memory::UniqueString _assetId, const StandardLayout::Mapping &_assetType) noexcept;
+
+    EMERGENCE_DELETE_ASSIGNMENT (ManualAssetConstructor);
+
+private:
+    ModifySingletonQuery modifyAssetManager;
+    InsertLongTermQuery insertAsset;
+};
+} // namespace Emergence::Celerity