Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Java 11 and migrate to Jersey >=2.37 #380

Closed
margaretha opened this issue May 10, 2022 · 15 comments · Fixed by #471
Closed

Update to Java 11 and migrate to Jersey >=2.37 #380

margaretha opened this issue May 10, 2022 · 15 comments · Fixed by #471
Assignees
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@margaretha
Copy link
Contributor

margaretha commented May 10, 2022

Issuehunt badges

Kustvakt has been developed using Java 8 and Jersey 1.19.x. Since Jersey 1.19.x isn't compatible with Java 11, we also need to migrate Kustvakt to Jersey 2.29 at least.


IssueHunt Summary

abcpro1 abcpro1 has been rewarded.

Backers (Total: $555.00)

Submitted pull Requests


Tips

@kupietz
Copy link
Member

kupietz commented May 10, 2022

Jersey 1->2 migration seems to be some work, in the case of Kustvakt. The latest guide seems to be here.

@kupietz kupietz changed the title Update to Java 11 and migration to Jersey 2 Update to Java 11 and migrate to Jersey >=2.37 Oct 7, 2022
@issuehunt-oss
Copy link

issuehunt-oss bot commented Oct 12, 2022

@kupietz has funded $20.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Oct 12, 2022
@kupietz
Copy link
Member

kupietz commented Oct 12, 2022

A fix should upgrade the jersey-version in core/pom.xml, lite/pom.xml, and full/pom.xml from 1.19.4 to >=2.37 and java-version from 1.8 to 11, migrate the sources as necessary and pass all tests (see ci_test.yml).

To collect the bounty, in addition, a bogus self-employment verification questionnaire will have to be completed.

IDS employees are not eligible for the bounty.

@issuehunt-oss
Copy link

issuehunt-oss bot commented Oct 13, 2022

@kupietz has funded $535.00 to this issue.


@abcpro1
Copy link
Contributor

abcpro1 commented Oct 15, 2022

Hi. I would like to work on this issue. Can you please assign me?

@kupietz
Copy link
Member

kupietz commented Oct 15, 2022

Yes, great! However, before starting with the work, you'd first have to complete the first three pages of our bogus self-employment verification questionnaire and send it to me. Unfortunately, we only have the official German version, but I guess you can translate it.

@abcpro1
Copy link
Contributor

abcpro1 commented Oct 15, 2022

Give me an email address to which I will send the filled in form.

@kupietz
Copy link
Member

kupietz commented Oct 15, 2022

Give me an email address to which I will send the filled in form.

kupietz@ids-mannheim.de

@abcpro1
Copy link
Contributor

abcpro1 commented Oct 15, 2022

I have sent it.

@sarthakkathpalia
Copy link

Is this issue still open? Would like to work on it. @kupietz

@kupietz
Copy link
Member

kupietz commented Nov 8, 2022

Is this issue still open? Would like to work on it. @kupietz

Thanks for the offer, bot @abcpro1 is already working on it, and is apparently almost done.

@abcpro1
Copy link
Contributor

abcpro1 commented Nov 12, 2022

I opened a pull request with the complete work ready for review at #471.

@kupietz kupietz reopened this Nov 14, 2022
@kupietz
Copy link
Member

kupietz commented Nov 14, 2022

Resolved via #471

@issuehunt-oss
Copy link

issuehunt-oss bot commented Nov 14, 2022

@kupietz has rewarded $499.50 to @abcpro1. See it on IssueHunt

  • 💰 Total deposit: $555.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $55.50

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Nov 14, 2022
@abcpro1
Copy link
Contributor

abcpro1 commented Nov 14, 2022

As an additional note, if an upgrade to jersey 3.1.0 is needed in the future, Spring 6 is required which in turn requires Java 17 at minimum. Ref1, Ref2.

idsgerrit pushed a commit that referenced this issue Nov 16, 2022
see #380 (comment), see #380 (comment)

Change-Id: I0e035b93947d9722ae3a1f52915748a94253acc4
@kupietz kupietz closed this as completed Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants