Hieule/selection #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korede-TA
requested changes
Feb 2, 2020
src/model.rs
Outdated
| self.l_select_cell.row_to_string(), | ||
| self.l_select_cell.col_to_string() | ||
| ); | ||
| self.select_grammar.push(coord); |
There was a problem hiding this comment.
i think what you want to do here is add all the grammars between f_select_cell and l_select_cell to self.select_grammar. you'll need to loop through the coordinates somehow. one thing you might want to check for is that f_select_cell and l_select_cell have the same parent.
There was a problem hiding this comment.
yeah. It's just some testing for that. Got it. Thank man
| pub col_widths: HashMap<Col, f64>, | ||
| pub row_heights: HashMap<Row, f64>, | ||
|
|
||
| pub select_grammar: Vec<Coordinate>, |
Korede-TA
requested changes
Feb 5, 2020
Korede-TA
approved these changes
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you guys help me to understand the code quick?
I want the action onclick for the cell it will push the coord to selectCells vector; and then if user hold the shift and click on other cell, it will put the next coord to that vector. There are something that I need to figure out.
How can I check or print out what coord in the selectCell?
How can I change the class with the CSS for those cell?
I will try continue to work on this for today