Yom Hashoah should be returned where 28 Iyar occurs on Monday #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KosherJava
approved these changes
Nov 22, 2017
BehindTheMath
added a commit
to BehindTheMath/KosherZmanim
that referenced
this pull request
Nov 23, 2017
BehindTheMath
added a commit
to BehindTheMath/KosherZmanim
that referenced
this pull request
Nov 23, 2017
|
For the record, this change was about 28 Nissan, not Iyar. Sorry, for the confusing commentary, but the code change is accurate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that 27 Iyar occurs on Sunday, Yom Hashoah would occur on Monday the 28th. The 28th can actually never fall out on a Sunday.