Skip to content

Commit

Permalink
fix: make the opposition detection more reliable (#39)
Browse files Browse the repository at this point in the history
  • Loading branch information
Deuchnord committed Jan 8, 2022
1 parent a99ef9d commit 761ec4e
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion kosmorrolib/events.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,9 @@ def _search_oppositions(start_time: Time, end_time: Time, timezone: int) -> [Eve
>>> _search_oppositions(get_timescale().utc(2021, 3, 20), get_timescale().utc(2021, 3, 21), 0)
[]
>>> _search_oppositions(get_timescale().utc(2022, 12, 24), get_timescale().utc(2022, 12, 25), 0)
[]
"""
earth = get_skf_objects()["earth"]
sun = get_skf_objects()["sun"]
Expand Down Expand Up @@ -187,7 +190,7 @@ def get_angle(time: Time):

times, _ = find_discrete(start_time, end_time, is_oppositing)
for time in times:
if get_angle(time) < 0:
if int(get_angle(time)) != 180:
# If the angle is negative, then it is actually a false positive.
# Just ignoring it.
continue
Expand Down

0 comments on commit 761ec4e

Please sign in to comment.