fix(ephemerides): fix a bug that made the ephemerides calculations im possible for the Poles #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Deuchnord
commented
May 22, 2021
Deuchnord
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Related issues | Fix #5 |
| Has BC-break | no |
| License | CeCILL-C |
…possible for the Poles
Deuchnord
force-pushed
the
fix/5-extreme-latitude
branch
from
bd1aa4a
to
ee78621
Compare
Deuchnord
pushed a commit
that referenced
this pull request
Jun 20, 2021
* chore: fix files to commit on tag * fix(ephemerides): fix a bug that made the ephemerides calculations impossible for the Poles (#21) * chore: fix the target branch on Dependabot's config * ci: remove Commitlint workflow (replaced by semantic-pull-request) (#25) * ci: remove Commitlint workflow (replaced by semantic-pull-request) * ci: fix doctests not running correctly on some OS and Python versions * Add season change event in events.py and enum.py * Add minor change in season change event * Add documentation, change enum constants, change output object of _search_earth_season_change * Minor changes to _search_earth_season_change * Update EventType enum, update class of details * Fix minor bugs * docs: Update docs for _search_earth_season_change and _search_conjunction.chore: make minor changes to _search_earth_season_change * Update: minor changes to match Python coding style. * Update: minor changes to match Python coding style. Docs: update docstring of _search_earth_season_change and _search_conjunction * test:update legacy tests for events.py. update: update enum.py and events.py to match black coding style. * Fix some minor issues with Black and Event.details field Co-authored-by: Jérôme Deuchnord <jerome@deuchnord.fr> Co-authored-by: Jérôme Deuchnord <Deuchnord@users.noreply.github.com> BREAKING CHANGE: the `Event.details` field is now a dictionary (was previously a string).
Deuchnord
pushed a commit
that referenced
this pull request
Oct 26, 2021
* chore: fix files to commit on tag * fix(ephemerides): fix a bug that made the ephemerides calculations impossible for the Poles (#21) * chore: fix the target branch on Dependabot's config * ci: remove Commitlint workflow (replaced by semantic-pull-request) (#25) * ci: remove Commitlint workflow (replaced by semantic-pull-request) * ci: fix doctests not running correctly on some OS and Python versions * Add season change event in events.py and enum.py * Add minor change in season change event * Add documentation, change enum constants, change output object of _search_earth_season_change * Minor changes to _search_earth_season_change * Update EventType enum, update class of details * Fix minor bugs * docs: Update docs for _search_earth_season_change and _search_conjunction.chore: make minor changes to _search_earth_season_change * Update: minor changes to match Python coding style. * Update: minor changes to match Python coding style. Docs: update docstring of _search_earth_season_change and _search_conjunction * test:update legacy tests for events.py. update: update enum.py and events.py to match black coding style. * Fix some minor issues with Black and Event.details field Co-authored-by: Jérôme Deuchnord <jerome@deuchnord.fr> Co-authored-by: Jérôme Deuchnord <Deuchnord@users.noreply.github.com> BREAKING CHANGE: the `Event.details` field is now a dictionary (was previously a string).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.