土屋の解答 #16
Open
土屋の解答 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4K1T
reviewed
Apr 10, 2019
| return true; | ||
| } else { | ||
| return false; | ||
| } |
| if(n >= 0) { | ||
| return n % 2 == 0 ? "正の偶数" : "正の奇数"; | ||
| }else{ | ||
| return n % 2 == 0 ? "負の偶数" : "負の奇数"; |
| return "合格"; | ||
| } else { | ||
| return "不合格"; | ||
|
|
| return "可"; | ||
| } else { | ||
| return "不可"; | ||
| } |
There was a problem hiding this comment.
ifの条件は整理されてていい感じです！
「ガード節」というキーワードで調べてみてください！
https://qiita.com/kouyan/items/7b8b456b626447a1e24e
Kotanin0
reviewed
Apr 15, 2019
| } | ||
| if (n == 1) { | ||
| return false; | ||
| } |
| if (n % i == 0) { | ||
|
|
||
| soinsu += " " + i; | ||
| n = n / i; |
|
|
||
| while (n > 0) { | ||
| nishinsu = (n % 2) + nishinsu; | ||
| n = n / 2; |
Kotanin0
reviewed
Apr 20, 2019
| for (int i = 0; i < list.size(); i++) { | ||
| returnArray[i] = list.get(i); | ||
| } | ||
| return returnArray; |
|
|
||
| } | ||
|
|
||
| // 並べ替えられた配列を返す | ||
| public static int[] sort(int[] n) { | ||
| Arrays.sort(n); |
| if (str.contains("ge")) { | ||
| return true; | ||
| } | ||
| return false; |
| if (n % 5 == 0 || s.contains("5")) { | ||
| return "buzz"; | ||
| } | ||
| return""; |
There was a problem hiding this comment.
せっかくPractice016,017で作ったメソッド、使いましょう。
| } | ||
|
|
||
| public static boolean isMailAddress(String s) { | ||
|
|
||
| return false; | ||
| return s.matches("^[\\w.!#$%&'*+/=?^_`{|}~-]+@[\\w.!#$%&'*+/=?^_`{|}~-]+(\\.com$|\\.co.jp|\\.ne.jp$)"); |
There was a problem hiding this comment.
これだと hoge@hoge.neajp のときにtrueになっちゃいませんか？
. の扱いに気をつけましょう。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.