Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CellConversionException in DataColumn<String?>.convertToDouble(locale) #190

Merged
merged 3 commits into from
Nov 28, 2022
Merged

CellConversionException in DataColumn<String?>.convertToDouble(locale) #190

merged 3 commits into from
Nov 28, 2022

Conversation

Kopilov
Copy link
Contributor

@Kopilov Kopilov commented Nov 28, 2022

CellConversionException logic at parsing Double-s per locale

@Jolanrensen Jolanrensen added this to the 0.9.0 milestone Nov 28, 2022
@Jolanrensen
Copy link
Collaborator

return can be lifted out of if statement.
Can you provide some tests where the CellConversionException happens as well? :)

@Kopilov
Copy link
Contributor Author

Kopilov commented Nov 28, 2022

return can be lifted out of if statement.

Done

Can you provide some tests where the CellConversionException happens as well? :)

Added to fun `convert to value class exceptions`()

@Kopilov Kopilov force-pushed the cell_conversion_exception_double branch from d4af5e8 to fcc0800 Compare November 28, 2022 14:38
@Jolanrensen
Copy link
Collaborator

Awesome! Looks good :)

@Jolanrensen Jolanrensen merged commit d9d5f92 into Kotlin:master Nov 28, 2022
@Kopilov Kopilov deleted the cell_conversion_exception_double branch December 2, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Kopilov @Jolanrensen